Need parameter data_format in definition for deaggregate_records to use with Boto3

[jesshart]

Versions

Python 3.8.6
aws_kinesis_agg 1.1.6

Referencing

kinesis-aggregation/python/aws_kinesis_agg/deaggregator.py

Line 173 in 398fbd4

def deaggregate_records(records):

kinesis-aggregation/python/aws_kinesis_agg/deaggregator.py

Line 185 in 398fbd4

return_records.extend(iter_deaggregate_records(records))

Recommended Changes

def deaggregate_records(records, data_format=None)

    return_records.extend(iter_deaggregate_records(records, data_format))        

If a developer using Boto3 is to use the deaggregate_records from deaggregator.py then they would need to be able to pass a parameter 'data_format='Boto3' since there is no way for the later called iter_deaggregate_records() to know about its format.

Referencing Function Definition

kinesis-aggregation/python/aws_kinesis_agg/deaggregator.py

Lines 173 to 186 in 398fbd4

	def deaggregate_records(records):
	"""Given a set of Kinesis records, deaggregate any records that were packed using the
	Kinesis Producer Library into individual records. This method will be a no-op for any
	records that are not aggregated (but will still return them).
	records - The list of raw Kinesis records to deaggregate. (list of dict)
	return value - A list of Kinesis user records greater than or equal to the size of the
	input record list. (list of dict)"""
	# Use the existing generator function to deaggregate all the records
	return_records = []
	return_records.extend(iter_deaggregate_records(records))
	return return_records