Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-apigateway-dynamodb enable passing of methodOptions for use in addProxyMethodToApiResource #909

Open
2 tasks
kevohagan opened this issue Feb 20, 2023 · 1 comment
Labels
feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged

Comments

@kevohagan
Copy link

The addProxyMethodToApiResource accepts a params.methodOptions to be able to override/complement the default options defined

const overridenProps = consolidateProps(defaultMethodOptions, params.methodOptions);

unfortunately the aws-apigateway-dynamodb construct does not pass this in its call the the addProxyMethodToApiResource method e.g

Use Case

Overriding default headers to specify CORS values would be a great use case to do it whilst overriding the default method responses.

Proposed Solution

Be able to pass in methodOptions as aditional opitional attribute . e.g : createIntegrationMethodOptions

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@kevohagan kevohagan added feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged labels Feb 20, 2023
@biffgaut
Copy link
Contributor

Thanks, we'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged
Projects
None yet
Development

No branches or pull requests

2 participants