Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lowercase fine-tuning-6b deployment name due to CDK resource naming constraints #245

Merged
merged 3 commits into from
Sep 30, 2024
Merged

fix: lowercase fine-tuning-6b deployment name due to CDK resource naming constraints #245

merged 3 commits into from
Sep 30, 2024

Conversation

kukushking
Copy link
Contributor

Describe your changes

  • lowercase fine-tuning-6b deployment name due to CDK resource naming constraints

Checklist before requesting a review

  • I updated CHANGELOG.MD with a description of my changes
  • If the change was to a module, I ran the code validation script (scripts/validate.sh)
  • If the change was to a module, I have added thorough tests
  • If the change was to a module, I have added/updated the module's README.md
  • If a module was added, I added a reference to the module to the repository's README.md
  • I verified that my code deploys successfully using seedfarmer apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kukushking kukushking self-assigned this Sep 30, 2024
@kukushking kukushking requested a review from a team September 30, 2024 11:36
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: aadae52
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

EthanBunce
EthanBunce previously approved these changes Sep 30, 2024
View reviewed changes
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: a58d153
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking kukushking merged commit 859bf3a into awslabs:main Sep 30, 2024
2 checks passed
@kukushking kukushking deleted the fix/fine-tuning-6b branch September 30, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clokep clokep clokep approved these changes

@EthanBunce EthanBunce EthanBunce approved these changes

Assignees

@kukushking kukushking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kukushking @malachi-constant @clokep @EthanBunce