chore: Add validation step for one-click template #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9d613ff.
LeonLuttenberger
commented
Mar 1, 2024
.github/workflows/module-checks.yml
Outdated
| @@ -3,11 +3,11 @@ name: Module Checks | |||
| on: | |||
| push: | |||
| branches: ["main"] | |||
| paths: ['modules/**', '.github/workflows/module-checks.yml'] | |||
| paths: ["modules/**", "requirements-dev.txt", ".github/workflows/module-checks.yml"] | |||
There was a problem hiding this comment.
Updates to requirements-dev.txt can change how our linters behave, which could lead to errors in our validation scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add
cfn-lintvalidation step for one-click template.Checklist before requesting a review
CHANGELOG.MDwith a description of my changesscripts/validate.sh)seedfarmer applyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.