feat: add SageMaker Endpoint module #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Kukushkin <[email protected]>
Signed-off-by: Anton Kukushkin <[email protected]>
Signed-off-by: Anton Kukushkin <[email protected]>
Signed-off-by: Anton Kukushkin <[email protected]>
Signed-off-by: Anton Kukushkin <[email protected]>
LeonLuttenberger
previously approved these changes
Feb 5, 2024
Signed-off-by: Anton Kukushkin <[email protected]>
Signed-off-by: Anton Kukushkin <[email protected]>
Signed-off-by: Anton Kukushkin <[email protected]>
LeonLuttenberger
previously approved these changes
Feb 5, 2024
dgraeber
approved these changes
Feb 5, 2024
dgraeber
requested changes
Feb 5, 2024
srinivasreddych
previously approved these changes
Feb 6, 2024
Signed-off-by: Anton Kukushkin <[email protected]>
kukushking
dismissed stale reviews from srinivasreddych and LeonLuttenberger
via
2bf1968
…ping Signed-off-by: Anton Kukushkin <[email protected]>
Signed-off-by: Anton Kukushkin <[email protected]>
Signed-off-by: Anton Kukushkin <[email protected]>
Signed-off-by: Anton Kukushkin <[email protected]>
Signed-off-by: Anton Kukushkin <[email protected]>
kukushking
commented
Feb 6, 2024
| endpoint.add_dependency(endpoint_config) | ||
| self.endpoint = endpoint | ||
| self.endpoint_url = ( | ||
| f"https://runtime.sagemaker.{self.region}.amazonaws.com/endpoints/{endpoint.attr_endpoint_name}/invocations" |
There was a problem hiding this comment.
This is a bit clunky but I do not see a way to get endpoint attr from the L1 CfnEdnpoint construct, nor the API to get it. DescribeEndpoint, DescribeEndpointConfig do not return the Url.
There was a problem hiding this comment.
Can you check what does endpoint.ref return?
There was a problem hiding this comment.
Just checked - returns endpoint ARN
Signed-off-by: Anton Kukushkin <[email protected]>
dgraeber
approved these changes
Feb 6, 2024
srinivasreddych
approved these changes
Feb 6, 2024
| endpoint.add_dependency(endpoint_config) | ||
| self.endpoint = endpoint | ||
| self.endpoint_url = ( | ||
| f"https://runtime.sagemaker.{self.region}.amazonaws.com/endpoints/{endpoint.attr_endpoint_name}/invocations" |
There was a problem hiding this comment.
Can you check what does endpoint.ref return?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.