Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(s2n-tls-hyper): Gracefully shutdown client in tests #4855

Open
goatgoose opened this issue Oct 22, 2024 · 1 comment
Open

tests(s2n-tls-hyper): Gracefully shutdown client in tests #4855

goatgoose opened this issue Oct 22, 2024 · 1 comment

Comments

@goatgoose
Copy link
Contributor

Problem:

The hyper client isn't currently capable of shutting down gracefully, and immediately closes its socket after sendings its shutdown to the server. This causes the server to emit a NotConnected socket error when attempting to send its shutdown to the client.

#4838 adds a s2n-tls hyper server for localhost testing purposes. Since the s2n-tls hyper client can't be configured to shutdown gracefully, the server must be configured to ignore NotConnected errors.

Solution:

After the hyper client can be configured to shutdown gracefully, this should be implemented in the s2n-tls-hyper tests. Then, the NotConnected exception should be removed from the test server.

@goatgoose goatgoose changed the title s2n-tls-hyper: Gracefully shutdown client in tests tests(s2n-tls-hyper): Gracefully shutdown client in tests Oct 22, 2024
@goatgoose
Copy link
Contributor Author

Issue opened to hyper: hyperium/hyper#3775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant