From 74f43c36bd361e91433f704a8208112e97d354aa Mon Sep 17 00:00:00 2001 From: Matthew Becker Date: Fri, 13 Mar 2020 11:08:51 -0500 Subject: [PATCH] NTH - Add image.pullSecrets variable for private docker registries (#76) * Add image.pullSecrets variable for private docker registries * updating chart version and app version --- stable/aws-node-termination-handler/Chart.yaml | 4 ++-- stable/aws-node-termination-handler/README.md | 1 + .../aws-node-termination-handler/templates/daemonset.yaml | 6 ++++++ stable/aws-node-termination-handler/values.yaml | 3 ++- 4 files changed, 11 insertions(+), 3 deletions(-) diff --git a/stable/aws-node-termination-handler/Chart.yaml b/stable/aws-node-termination-handler/Chart.yaml index 90b49fae6..8465fc340 100644 --- a/stable/aws-node-termination-handler/Chart.yaml +++ b/stable/aws-node-termination-handler/Chart.yaml @@ -1,8 +1,8 @@ apiVersion: v1 name: aws-node-termination-handler description: A Helm chart for the AWS Node Termination Handler -version: 0.6.0 -appVersion: 1.2.0 +version: 0.7.0 +appVersion: 1.3.0 home: https://github.com/aws/eks-charts icon: https://raw.githubusercontent.com/aws/eks-charts/master/docs/logo/aws.png sources: diff --git a/stable/aws-node-termination-handler/README.md b/stable/aws-node-termination-handler/README.md index 319454f4f..c3f7e16fd 100644 --- a/stable/aws-node-termination-handler/README.md +++ b/stable/aws-node-termination-handler/README.md @@ -52,6 +52,7 @@ Parameter | Description | Default `image.repository` | image repository | `amazon/aws-node-termination-handler` `image.tag` | image tag | `` `image.pullPolicy` | image pull policy | `IfNotPresent` +`image.pullSecrets` | image pull secrets (for private docker registries) | `[]` `deleteLocalData` | Tells kubectl to continue even if there are pods using emptyDir (local data that will be deleted when the node is drained). | `false` `gracePeriod` | (DEPRECATED: Renamed to podTerminationGracePeriod) The time in seconds given to each pod to terminate gracefully. If negative, the default value specified in the pod will be used. | `30` `podTerminationGracePeriod` | The time in seconds given to each pod to terminate gracefully. If negative, the default value specified in the pod will be used. | `30` diff --git a/stable/aws-node-termination-handler/templates/daemonset.yaml b/stable/aws-node-termination-handler/templates/daemonset.yaml index 63d810ba3..23f38e958 100644 --- a/stable/aws-node-termination-handler/templates/daemonset.yaml +++ b/stable/aws-node-termination-handler/templates/daemonset.yaml @@ -101,6 +101,12 @@ spec: nodeSelector: {{- toYaml . | nindent 8 }} {{- end }} + {{- if .Values.image.pullSecrets }} + imagePullSecrets: + {{- range .Values.image.pullSecrets }} + - name: {{ . }} + {{- end }} + {{- end }} {{- with .Values.affinity }} affinity: {{- toYaml . | nindent 8 }} diff --git a/stable/aws-node-termination-handler/values.yaml b/stable/aws-node-termination-handler/values.yaml index 677f9e756..6c0435406 100644 --- a/stable/aws-node-termination-handler/values.yaml +++ b/stable/aws-node-termination-handler/values.yaml @@ -4,8 +4,9 @@ image: repository: amazon/aws-node-termination-handler - tag: v1.2.0 + tag: v1.3.0 pullPolicy: IfNotPresent + pullSecrets: [] nameOverride: "" fullnameOverride: ""