Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not validate MD5 if checksum value supplied #5278

Merged

Conversation

davidh44
Copy link
Contributor

@davidh44 davidh44 commented Jun 10, 2024

Motivation and Context

Skip MD5 validation if checksum value is supplied.
Md5 is not supported for S3Express, and throws an error.

Modifications

Add check in ChecksumsEnabledValidator for checksum value field on request

Testing

Added unit + integ tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@davidh44 davidh44 requested a review from a team as a code owner June 10, 2024 16:21
Copy link

sonarcloud bot commented Jun 12, 2024

@davidh44 davidh44 merged commit 859c2b1 into master Jun 12, 2024
17 checks passed
@davidh44 davidh44 deleted the hdavidh/do-not-validate-md5-if-checksum-value-supplied branch June 12, 2024 18:27
akidambisrinivasan pushed a commit to akidambisrinivasan/aws-sdk-java-v2 that referenced this pull request Jun 28, 2024
* Do not validate Md5 if checksum value supplied

* Do not validate Md5 if checksum value supplied

* Add changelog

* Add unit tests

* Add back deleted test

* Add back deleted test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants