Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scheduler-alpha): unit test schedule with Lambda alias as target #31873

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

samson-keung
Copy link
Contributor

@samson-keung samson-keung commented Oct 24, 2024

Issue # (if applicable)

Tracking #31785.

Reason for this change

Missing this test case.

Description of changes

Adding a unit test to verify Schedule works with Lambda Alias and correct permissions are added.

Description of how you validated changes

Unit test.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 24, 2024 06:15
@github-actions github-actions bot added the p2 label Oct 24, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 24, 2024
Copy link
Contributor

mergify bot commented Oct 24, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 176bb17
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 886283e into aws:main Oct 24, 2024
12 checks passed
Copy link
Contributor

mergify bot commented Oct 24, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
@samson-keung samson-keung deleted the scheduler-unit-test-lambda-alias branch October 28, 2024 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants