feat(elasticloadbalancingv2): support target group level cross-zone settings for ALB and NLB #31814
Conversation
github-actions
bot
added
effort/small
github-actions
bot
added
the
distinguished-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
| @@ -805,4 +805,29 @@ describe('tests', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| // test cases for crossZoneEnabled | |||
| describe('crossZoneEnabled', () => { | |||
|
|
||
| // test cases for crossZoneEnabled | ||
| describe('crossZoneEnabled', () => { | ||
| test.each([true, false])('crossZoneEnabled can be %s', (crossZoneEnabled) => { |
aws-cdk-automation
added
pr/needs-maintainer-review
| TargetGroupAttributes: [ | ||
| { | ||
| Key: 'stickiness.enabled', | ||
| Value: 'false', | ||
| }, | ||
| ], |
There was a problem hiding this comment.
nit: Is this attribute always present for the ALB target group? This test could be clearer using Match.absent() like the NLB, but no worries if this can't be helped.
There was a problem hiding this comment.
Thanks.
I've update the test to TargetGroupAttributes to be undefined by using Lambda Target Type.
Co-authored-by: Leonardo Gama <[email protected]>
|
@Mergifyio refresh |
✅ Pull request refreshed |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #31790.
Reason for this change
To support target group level cross-zone settings for ALB and NLB
Description of changes
Add
crossZoneEnabledproperty tobaseTargetGroup.Description of how you validated changes
Add unit tests and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license