Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli-lib): cannot bootstrap specific environment #31713

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Oct 10, 2024

Issue

Closes #31656

Reason for this change

When boostrapping, users may need to explicitly provide the environment if it can be determined from the app or shell environment. Previously this was not possible using the cli-lib-alpha package.

Description of changes

Add a new argument to support environments.

Description of how you validated changes

Unit test case was added.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 labels Oct 10, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 10, 2024 09:33
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 10, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mrgrain mrgrain added pr-linter/exempt-integ-test The PR linter will not require integ test changes effort/small Small work item – less than a day of effort and removed effort/medium Medium work item – several days of effort labels Oct 10, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 10, 2024 09:41

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mrgrain mrgrain force-pushed the mrgrain/fix/cannot-bootstrap-environment branch 2 times, most recently from 5f4c7b6 to 85b23be Compare October 10, 2024 09:42
@mrgrain mrgrain force-pushed the mrgrain/fix/cannot-bootstrap-environment branch from 85b23be to 3fe53aa Compare October 10, 2024 09:43
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3fe53aa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 10, 2024
Copy link
Contributor

mergify bot commented Oct 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit fec4bb1 into main Oct 10, 2024
16 checks passed
@mergify mergify bot deleted the mrgrain/fix/cannot-bootstrap-environment branch October 10, 2024 10:28
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AwsCdkCli: Unable to provide Environment to Bootstrap command
3 participants