Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(elasticloadbalancingv2): add details about Network Load Balancer and EC2 IConnectable interface. #31704

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

ashishdhingra
Copy link
Contributor

Issue # (if applicable)

Closes #31644.

Reason for this change

User reported that using connections with NLB without security group specified, doesn't create security group automatically. NLB do not have security groups, and no automatic security group configuration is done.

Description of changes

Add details about Network Load Balancer and EC2 IConnectable interface.

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 9, 2024 02:33
@github-actions github-actions bot added bug This issue is a bug. p2 labels Oct 9, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 9, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 9, 2024
Copy link
Contributor

mergify bot commented Oct 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 14, 2024
Copy link
Contributor

mergify bot commented Oct 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a479ebb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Oct 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 78a7182 into main Oct 14, 2024
12 checks passed
@mergify mergify bot deleted the user/ashdhin/nlb-ec2-connections-issue31644 branch October 14, 2024 19:08
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(ElasticLoadBalancingV2): Security group missing when specifying Connections rules
3 participants