Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda): filterRule.null() returns empty array #31701

Merged
merged 7 commits into from
Oct 15, 2024

Conversation

xazhao
Copy link
Contributor

@xazhao xazhao commented Oct 8, 2024

Issue # (if applicable)

Closes #31458.

Reason for this change

According to the documentation here, the FilterPattern should be [null]. However, the function FilterRule.null() currently returns an empty array [] instead. It results an invalid filter pattern definition.

Description of changes

Change the return value from [] to [null]

Description of how you validated changes

Add an integration test to validate the new return value. Also with the old return value, the deployment will fail with error Invalid request provided: Invalid filter pattern definition. so it should break existing customers.

Checklist

BREAKING CHANGE: The function return value changes from String[] to any which could be a breaking change in some cases. However, the previous return value would fail the deployment hence it reduces the risk of breaking change.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort labels Oct 8, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 8, 2024 21:51
@github-actions github-actions bot added the p1 label Oct 8, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 8, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@xazhao xazhao added the pr-linter/exempt-breaking-change The PR linter will not require stability in stable modules label Oct 10, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 10, 2024 18:13

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 15, 2024
Copy link
Contributor

mergify bot commented Oct 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 15, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0800bd7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5830ee1 into aws:main Oct 15, 2024
15 checks passed
Copy link
Contributor

mergify bot commented Oct 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1 pr-linter/exempt-breaking-change The PR linter will not require stability in stable modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-lambda: FilterRule.null() returns empty array
3 participants