chore(kinesisfirehose-destinations): refactor logging to combine logGroup and logging properties into loggingConfig #31488
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
The
logging
andlogGroup
properties contain a restriction where alogGroup
cannot be provided iflogging
is set tofalse
. This was previously handled by error handling but we want to change this to make it impossible for a user to run into that scenario in the first place.Description of changes
BREAKING CHANGE: the
logging
andlogGroup
properties inDestinationLoggingProps
have been removed and replaced with a single optional propertyloggingConfig
which accepts a class of typeLoggingConfig
.Details
Combine the
logging
andlogGroup
properties into a single new optional property calledloggingConfig
which accepts a class of typeLoggingConfig
.LoggingConfig
is an abstract class which can be instantiated through either an instance ofEnableLogging
orDisableLogging
which can be used in the following 3 ways:Description of how you validated changes
unit + integ test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
…yptionKey