Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix spelling error of if #31353

Merged
merged 1 commit into from
Sep 7, 2024
Merged

chore: fix spelling error of if #31353

merged 1 commit into from
Sep 7, 2024

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Sep 7, 2024 •
edited
Loading

I saw this while reading the EC2 instance docs.

@github-actions github-actions bot added the p2 label Sep 7, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team September 7, 2024 15:11
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Sep 7, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Sep 7, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Sep 7, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1f595c0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mrgrain mrgrain added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Sep 7, 2024
@mrgrain
Copy link
Contributor

mrgrain commented Sep 7, 2024

Docs change. No need to run the cli tests.

@aws-cdk-automation aws-cdk-automation dismissed their stale review September 7, 2024 16:21

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-cli-test-run This PR needs CLI tests run against it. label Sep 7, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 7, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4fa7716 into aws:main Sep 7, 2024
29 of 32 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2024
@msambol msambol deleted the msambol-if branch September 7, 2024 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msambol @aws-cdk-automation @mrgrain