fix(location): dataSource property is not required

[mazyu36]

Issue # (if applicable)

Closes #31288.

Reason for this change

Currently, dataSource property in PlaceIndex class is optional.

But in CFn document and CloudFormation schema aws-location-placeindex.json, DataSource property is required.

The current default value in CDK is ESRI, but there's no clear reason for this, and I think it should be aligned with CFn (CloudFormation).

Description of changes

Make dataSource property required.

Description of how you validated changes

Updated unit tests and integ tests.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

BREAKING CHANGE: dataSource property in PlaceIndex class is now required.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[mazyu36]

Exemption Request: The results of the integration test snapshots have not changed, so they are not included.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: bd095dc
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[kaizencc]

I am going to close this PR because I definitely don't think we want to turn this property required on CDK and I don't see why the current default poses a problem right now. Can always revisit/reopen if we decide to change things up but that discussion should happen in an issue

[kaizencc]

A property being required on CFN does not necessarily mean we have to require it in CDK, if we can find a reasonable default for it. That's what we've done here -- we are not sending undefined into CFN and getting an error back, we are providing what we think is a sane default.

It sounds like you don't think that DataSource.ESRI is a reasonable default -- before making that change, I think that's a better discussion to have in an issue.

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.