Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): support alb controller versions 2.7.0-2.8.2 #31264

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Aug 30, 2024

As #29959 has been stale for a while, I am submitting this PR to follow up.

Issue # (if applicable)

Closes #31082

Reason for this change

Description of changes

iam policy files were downloaded using this script

#!/bin/bash

versions=("2.7.0" "2.7.1" "2.7.2" "2.8.0" "2.8.1" "2.8.2")
target_dir="/workspace/aws-cdk/packages/aws-cdk-lib/aws-eks/lib/addons"

for version in "${versions[@]}"; do
    url="https://raw.githubusercontent.com/kubernetes-sigs/aws-load-balancer-controller/v${version}/docs/install/iam_policy.json"
    filename="alb-iam_policy-v${version}.json"
    target_file="${target_dir}/${filename}"

    echo "Downloading ${url} to ${target_file}"
    curl -s "${url}" -o "${target_file}"
done

helm repo updated using

helm repo add eks https://aws.github.io/eks-charts
helm repo update
helm search repo aws-load-balancer-controller --versions --output json

get the app_version and helm version mapping using

$ helm search repo aws-load-balancer-controller --versions --output json | jq -r '.[] | select(.app_version | startswith("v2")) | "\(.app_version) \(.version)"'
v2.8.2 1.8.2
v2.8.1 1.8.1
v2.8.0 1.8.0
v2.7.2 1.7.2
v2.7.1 1.7.1
v2.7.0 1.7.0

Description of how you validated changes

  • parameterized tests in the unit tests
  • using the latest version in the integ test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 30, 2024 03:07
@github-actions github-actions bot added the p2 label Aug 30, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 30, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. labels Aug 30, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 30, 2024 04:31

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@pahud pahud marked this pull request as ready for review August 30, 2024 04:31
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 30, 2024
Copy link
Contributor

mergify bot commented Sep 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 4, 2024
Copy link
Contributor

mergify bot commented Sep 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6e810b6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a3863a6 into aws:main Sep 4, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Sep 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

github-actions bot commented Sep 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eks: Support latest AWS Load Balancer Controller versions
3 participants