feat(core): Schedule class
#27105
Merged
feat(core): Schedule class
#27105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckupPlanRule.scheduleExpression
…uz of jsii limitation
aws-cdk-automation
previously requested changes
Sep 11, 2023
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
kaizencc
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
rix0rrr
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Nice! I'm conditionally approving this to allow you to get on with things.
A potentially even nicer solution to get rid of the Schedule subclass proliferation (I didn't know it had gotten that bad) could be to just have the singular core.Schedule class, that holds on to its input and returns it unrendered, and everyone accepts that class as a parameter.
It's then each service's responsibility to render that data to a string as the service would accept it.
In other words: holding+rendering is now the responsibility of each service's Schedule class, but we could make core.Schedule do the holding, and autoscaling.ScalableTarget do the rendering.
I'll leave it to you to decide.
jogold
reviewed
Sep 13, 2023
mrgrain
approved these changes
Sep 20, 2023
kaizencc
added
pr/do-not-merge
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
kaizencc
added a commit
that referenced
this pull request
Sep 25, 2023
kaizencc
added a commit
that referenced
this pull request
Sep 25, 2023
mergify bot
pushed a commit
to SvenKirschbaum/share.kirschbaum.cloud
that referenced
this pull request
Oct 1, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | | | lockFileMaintenance | All locks refreshed | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@aws-cdk/aws-apigatewayv2-alpha](https://togithub.com/aws/aws-cdk) | dependencies | minor | [`2.97.0-alpha.0` -> `2.99.1-alpha.0`](https://renovatebot.com/diffs/npm/@aws-cdk%2faws-apigatewayv2-alpha/2.97.0-alpha.0/2.99.1-alpha.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@aws-cdk/aws-apigatewayv2-authorizers-alpha](https://togithub.com/aws/aws-cdk) | dependencies | minor | [`2.97.0-alpha.0` -> `2.99.1-alpha.0`](https://renovatebot.com/diffs/npm/@aws-cdk%2faws-apigatewayv2-authorizers-alpha/2.97.0-alpha.0/2.99.1-alpha.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@aws-cdk/aws-apigatewayv2-integrations-alpha](https://togithub.com/aws/aws-cdk) | dependencies | minor | [`2.97.0-alpha.0` -> `2.99.1-alpha.0`](https://renovatebot.com/diffs/npm/@aws-cdk%2faws-apigatewayv2-integrations-alpha/2.97.0-alpha.0/2.99.1-alpha.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@aws-lambda-powertools/logger](https://togithub.com/aws-powertools/powertools-lambda-typescript/tree/main/packages/logger#readme) ([source](https://togithub.com/aws-powertools/powertools-lambda-typescript)) | dependencies | minor | [`1.13.1` -> `1.14.0`](https://renovatebot.com/diffs/npm/@aws-lambda-powertools%2flogger/1.13.1/1.14.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@aws-lambda-powertools/tracer](https://togithub.com/aws-powertools/powertools-lambda-typescript/tree/main/packages/tracer#readme) ([source](https://togithub.com/aws-powertools/powertools-lambda-typescript)) | dependencies | minor | [`1.13.1` -> `1.14.0`](https://renovatebot.com/diffs/npm/@aws-lambda-powertools%2ftracer/1.13.1/1.14.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@aws-sdk/client-dynamodb](https://togithub.com/aws/aws-sdk-js-v3/tree/main/clients/client-dynamodb) ([source](https://togithub.com/aws/aws-sdk-js-v3)) | dependencies | minor | [`3.418.0` -> `3.421.0`](https://renovatebot.com/diffs/npm/@aws-sdk%2fclient-dynamodb/3.418.0/3.421.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@aws-sdk/client-s3](https://togithub.com/aws/aws-sdk-js-v3/tree/main/clients/client-s3) ([source](https://togithub.com/aws/aws-sdk-js-v3)) | dependencies | minor | [`3.418.0` -> `3.421.0`](https://renovatebot.com/diffs/npm/@aws-sdk%2fclient-s3/3.418.0/3.421.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@aws-sdk/client-sesv2](https://togithub.com/aws/aws-sdk-js-v3/tree/main/clients/client-sesv2) ([source](https://togithub.com/aws/aws-sdk-js-v3)) | dependencies | minor | [`3.418.0` -> `3.421.0`](https://renovatebot.com/diffs/npm/@aws-sdk%2fclient-sesv2/3.418.0/3.421.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@aws-sdk/client-sfn](https://togithub.com/aws/aws-sdk-js-v3/tree/main/clients/client-sfn) ([source](https://togithub.com/aws/aws-sdk-js-v3)) | dependencies | minor | [`3.418.0` -> `3.421.0`](https://renovatebot.com/diffs/npm/@aws-sdk%2fclient-sfn/3.418.0/3.421.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@aws-sdk/s3-request-presigner](https://togithub.com/aws/aws-sdk-js-v3/tree/main/packages/s3-request-presigner) ([source](https://togithub.com/aws/aws-sdk-js-v3)) | dependencies | minor | [`3.418.0` -> `3.421.0`](https://renovatebot.com/diffs/npm/@aws-sdk%2fs3-request-presigner/3.418.0/3.421.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@mui/icons-material](https://mui.com/material-ui/material-icons/) ([source](https://togithub.com/mui/material-ui)) | dependencies | patch | [`5.14.9` -> `5.14.11`](https://renovatebot.com/diffs/npm/@mui%2ficons-material/5.14.9/5.14.11) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@mui/material](https://mui.com/material-ui/) ([source](https://togithub.com/mui/material-ui)) | dependencies | patch | [`5.14.10` -> `5.14.11`](https://renovatebot.com/diffs/npm/@mui%2fmaterial/5.14.10/5.14.11) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@mui/x-date-pickers](https://mui.com/x/react-date-pickers/) ([source](https://togithub.com/mui/mui-x)) | dependencies | minor | [`6.15.0` -> `6.16.0`](https://renovatebot.com/diffs/npm/@mui%2fx-date-pickers/6.15.0/6.16.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@reduxjs/toolkit](https://redux-toolkit.js.org) ([source](https://togithub.com/reduxjs/redux-toolkit)) | dependencies | patch | [`1.9.5` -> `1.9.6`](https://renovatebot.com/diffs/npm/@reduxjs%2ftoolkit/1.9.5/1.9.6) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | devDependencies | minor | [`18.17.19` -> `18.18.1`](https://renovatebot.com/diffs/npm/@types%2fnode/18.17.19/18.18.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/react](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | devDependencies | patch | [`18.2.22` -> `18.2.23`](https://renovatebot.com/diffs/npm/@types%2freact/18.2.22/18.2.23) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/react-dom](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react-dom) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | devDependencies | patch | [`18.2.7` -> `18.2.8`](https://renovatebot.com/diffs/npm/@types%2freact-dom/18.2.7/18.2.8) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/typescript-eslint) | devDependencies | patch | [`6.7.2` -> `6.7.3`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/6.7.2/6.7.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@typescript-eslint/parser](https://togithub.com/typescript-eslint/typescript-eslint) | devDependencies | patch | [`6.7.2` -> `6.7.3`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/6.7.2/6.7.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@vitejs/plugin-react](https://togithub.com/vitejs/vite-plugin-react/tree/main/packages/plugin-react#readme) ([source](https://togithub.com/vitejs/vite-plugin-react)) | devDependencies | minor | [`4.0.4` -> `4.1.0`](https://renovatebot.com/diffs/npm/@vitejs%2fplugin-react/4.0.4/4.1.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [aws-cdk](https://togithub.com/aws/aws-cdk) | devDependencies | minor | [`2.97.0` -> `2.99.1`](https://renovatebot.com/diffs/npm/aws-cdk/2.97.0/2.99.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [aws-cdk-lib](https://togithub.com/aws/aws-cdk) | dependencies | minor | [`2.97.0` -> `2.99.1`](https://renovatebot.com/diffs/npm/aws-cdk-lib/2.97.0/2.99.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [aws-sdk](https://togithub.com/aws/aws-sdk-js) | dependencies | minor | [`2.1463.0` -> `2.1467.0`](https://renovatebot.com/diffs/npm/aws-sdk/2.1463.0/2.1467.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [esbuild](https://togithub.com/evanw/esbuild) | dependencies | patch | [`0.19.3` -> `0.19.4`](https://renovatebot.com/diffs/npm/esbuild/0.19.3/0.19.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [axios](https://axios-http.com) ([source](https://togithub.com/axios/axios)) | dependencies | patch | [`1.5.0` -> `1.5.1`](https://renovatebot.com/diffs/npm/axios/1.5.0/1.5.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [glob](https://togithub.com/isaacs/node-glob) | devDependencies | patch | [`10.3.6` -> `10.3.10`](https://renovatebot.com/diffs/npm/glob/10.3.6/10.3.10) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [web-vitals](https://togithub.com/GoogleChrome/web-vitals) | dependencies | minor | [`3.4.0` -> `3.5.0`](https://renovatebot.com/diffs/npm/web-vitals/3.4.0/3.5.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | 🔧 This Pull Request updates lock files to use the latest dependency versions. --- ### Release Notes <details> <summary>aws-powertools/powertools-lambda-typescript (@​aws-lambda-powertools/logger)</summary> ### [`v1.14.0`](https://togithub.com/aws-powertools/powertools-lambda-typescript/blob/HEAD/CHANGELOG.md#1140-2023-09-29) [Compare Source](https://togithub.com/aws-powertools/powertools-lambda-typescript/compare/v1.13.1...v1.14.0) ##### Features - **idempotency:** add idempotency decorator ([#​1723](https://togithub.com/aws-powertools/powertools-lambda-typescript/issues/1723)) ([d138673](https://togithub.com/aws-powertools/powertools-lambda-typescript/commit/d138673a33ff31f40b225dc046b2ff8258d0a97d)) - **layers:** add `arm64` to integration test matrix ([#​1720](https://togithub.com/aws-powertools/powertools-lambda-typescript/issues/1720)) ([61ad5ac](https://togithub.com/aws-powertools/powertools-lambda-typescript/commit/61ad5ac3bcf7742684aeec28553ec294696f3301)) - **tracer:** add try/catch logic to decorator and middleware close ([#​1716](https://togithub.com/aws-powertools/powertools-lambda-typescript/issues/1716)) ([be16b59](https://togithub.com/aws-powertools/powertools-lambda-typescript/commit/be16b599b8023f95572234fb222ea70aea5b3f17)) #### [1.13.1](https://togithub.com/aws-powertools/powertools-lambda-typescript/compare/v1.13.0...v1.13.1) (2023-09-21) ##### Bug Fixes - **maintenance:** remove upper peer dependency Middy ([#​1705](https://togithub.com/aws-powertools/powertools-lambda-typescript/issues/1705)) ([df21ec8](https://togithub.com/aws-powertools/powertools-lambda-typescript/commit/df21ec8761b1be511c13c28fedd41bf0e2851061)) </details> <details> <summary>aws/aws-sdk-js-v3 (@​aws-sdk/client-dynamodb)</summary> ### [`v3.421.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-dynamodb/CHANGELOG.md#34210-2023-09-27) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.420.0...v3.421.0) **Note:** Version bump only for package [@​aws-sdk/client-dynamodb](https://togithub.com/aws-sdk/client-dynamodb) ### [`v3.420.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-dynamodb/CHANGELOG.md#34200-2023-09-26) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.418.0...v3.420.0) ##### Features - **client-dynamodb:** Amazon DynamoDB now supports Incremental Export as an enhancement to the existing Export Table ([4ff14d6](https://togithub.com/aws/aws-sdk-js-v3/commit/4ff14d6b1c3acbe29e31b5e053270017fbb88bce)) </details> <details> <summary>aws/aws-sdk-js-v3 (@​aws-sdk/client-s3)</summary> ### [`v3.421.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-s3/CHANGELOG.md#34210-2023-09-27) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.420.0...v3.421.0) **Note:** Version bump only for package [@​aws-sdk/client-s3](https://togithub.com/aws-sdk/client-s3) ### [`v3.420.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-s3/CHANGELOG.md#34200-2023-09-26) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.418.0...v3.420.0) ##### Features - **client-s3:** This release adds a new field COMPLETED to the ReplicationStatus Enum. You can now use this field to validate the replication status of S3 objects using the AWS SDK. ([33e5436](https://togithub.com/aws/aws-sdk-js-v3/commit/33e5436ac8f94d237f738d00df8d2c667bf7f875)) </details> <details> <summary>aws/aws-sdk-js-v3 (@​aws-sdk/client-sesv2)</summary> ### [`v3.421.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-sesv2/CHANGELOG.md#34210-2023-09-27) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.418.0...v3.421.0) **Note:** Version bump only for package [@​aws-sdk/client-sesv2](https://togithub.com/aws-sdk/client-sesv2) </details> <details> <summary>aws/aws-sdk-js-v3 (@​aws-sdk/client-sfn)</summary> ### [`v3.421.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-sfn/CHANGELOG.md#34210-2023-09-27) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.418.0...v3.421.0) **Note:** Version bump only for package [@​aws-sdk/client-sfn](https://togithub.com/aws-sdk/client-sfn) </details> <details> <summary>aws/aws-sdk-js-v3 (@​aws-sdk/s3-request-presigner)</summary> ### [`v3.421.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/packages/s3-request-presigner/CHANGELOG.md#34210-2023-09-27) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.420.0...v3.421.0) **Note:** Version bump only for package [@​aws-sdk/s3-request-presigner](https://togithub.com/aws-sdk/s3-request-presigner) ### [`v3.420.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/packages/s3-request-presigner/CHANGELOG.md#34200-2023-09-26) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.418.0...v3.420.0) **Note:** Version bump only for package [@​aws-sdk/s3-request-presigner](https://togithub.com/aws-sdk/s3-request-presigner) </details> <details> <summary>mui/material-ui (@​mui/icons-material)</summary> ### [`v5.14.11`](https://togithub.com/mui/material-ui/blob/HEAD/CHANGELOG.md#51411) [Compare Source](https://togithub.com/mui/material-ui/compare/v5.14.9...v5.14.11) *Sep 26, 2023* A big thanks to the 23 contributors who made this release possible. This release was mostly about 🐛 bug fixes and 📚 documentation improvements. ##### `@mui/[email protected]` - \[Autocomplete] Re-export `AutocompleteValue` to make it available from path import ([#​38638](https://togithub.com/mui/material-ui/issues/38638)) [@​vadimka123](https://togithub.com/vadimka123) - \[Select]\[material-ui] Missing aria-multiselectable attribute on multiple Select component ([#​38855](https://togithub.com/mui/material-ui/issues/38855)) [@​gitstart](https://togithub.com/gitstart) - \[l10n] labelDisplayedRows is added for trTR localization ([#​39056](https://togithub.com/mui/material-ui/issues/39056)) [@​tebersefa](https://togithub.com/tebersefa) ##### `@mui/[email protected]` - Support RSC in `isMuiElement` util ([#​38129](https://togithub.com/mui/material-ui/issues/38129)) [@​sai6855](https://togithub.com/sai6855) ##### `@mui/[email protected]` - \[NumberInput] Support adornments ([#​38900](https://togithub.com/mui/material-ui/issues/38900)) [@​anle9650](https://togithub.com/anle9650) - \[Menu] Align external props handling for useMenu/MenuButton/MenuItem ([#​38946](https://togithub.com/mui/material-ui/issues/38946)) [@​mj12albert](https://togithub.com/mj12albert) - \[Select] Align external props handling ([#​39038](https://togithub.com/mui/material-ui/issues/39038)) [@​mj12albert](https://togithub.com/mj12albert) - \[TextareaAutosize] Simplify logic and add test ([#​38728](https://togithub.com/mui/material-ui/issues/38728)) [@​oliviertassinari](https://togithub.com/oliviertassinari) ##### `@mui/[email protected]` - \[Button] Fix disabled button styling when component prop is provided ([#​38996](https://togithub.com/mui/material-ui/issues/38996)) [@​sai6855](https://togithub.com/sai6855) - \[Drawer] Add missing `JoyDrawer` in theme components ([#​39074](https://togithub.com/mui/material-ui/issues/39074)) [@​Studio384](https://togithub.com/Studio384) ##### `@mui/[email protected]` - \[FormControl] Copy v5 FormControl ([#​39039](https://togithub.com/mui/material-ui/issues/39039)) [@​mj12albert](https://togithub.com/mj12albert) ##### `@mui/[email protected]` - \[TreeView] Fix JSDoc comments in TreeView and TreeItem ([#​38874](https://togithub.com/mui/material-ui/issues/38874)) [@​jergason](https://togithub.com/jergason) ##### Docs - Improve focus trap demo ([#​38985](https://togithub.com/mui/material-ui/issues/38985)) [@​oliviertassinari](https://togithub.com/oliviertassinari) - Add Tailwind CSS + plain CSS demo on the Tabs page ([#​39000](https://togithub.com/mui/material-ui/issues/39000)) [@​alisasanib](https://togithub.com/alisasanib) - Improve the default theme viewer design ([#​39049](https://togithub.com/mui/material-ui/issues/39049)) [@​danilo-leal](https://togithub.com/danilo-leal) - Add live demo with CssVarsProvider ([#​38792](https://togithub.com/mui/material-ui/issues/38792)) [@​oliviertassinari](https://togithub.com/oliviertassinari) - Fix wrong hash on Card's page ([#​39151](https://togithub.com/mui/material-ui/issues/39151)) [@​mnajdova](https://togithub.com/mnajdova) - Revise the Drawer page ([#​38988](https://togithub.com/mui/material-ui/issues/38988)) [@​danilo-leal](https://togithub.com/danilo-leal) - Simplify the button's loading indicator demo ([#​39082](https://togithub.com/mui/material-ui/issues/39082)) [@​danilo-leal](https://togithub.com/danilo-leal) - Fix the Templates link on the Overview page ([#​39086](https://togithub.com/mui/material-ui/issues/39086)) [@​danilo-leal](https://togithub.com/danilo-leal) - Refine the Sign in template ([#​38942](https://togithub.com/mui/material-ui/issues/38942)) [@​zanivan](https://togithub.com/zanivan) - Add `use-count-up` integration with the Circular Progress ([#​38952](https://togithub.com/mui/material-ui/issues/38952)) [@​anon-phantom](https://togithub.com/anon-phantom) ##### Core - \[blog] Add a company values blog post ([#​38802](https://togithub.com/mui/material-ui/issues/38802)) [@​mikailaread](https://togithub.com/mikailaread) - \[core] Downgrade lerna to 7.2.0 ([#​39149](https://togithub.com/mui/material-ui/issues/39149)) [@​michaldudak](https://togithub.com/michaldudak) - \[core] Simplify docs feedback interaction ([#​39075](https://togithub.com/mui/material-ui/issues/39075)) [@​alexfauquette](https://togithub.com/alexfauquette) - \[core] Improve ref type definition ([#​38903](https://togithub.com/mui/material-ui/issues/38903)) [@​oliviertassinari](https://togithub.com/oliviertassinari) - \[core] Simplify career ([#​39112](https://togithub.com/mui/material-ui/issues/39112)) [@​oliviertassinari](https://togithub.com/oliviertassinari) - \[core] Update Babel types along with source packages ([#​39070](https://togithub.com/mui/material-ui/issues/39070)) [@​michaldudak](https://togithub.com/michaldudak) - \[core] Add a comment to explain `useEnhancedEffect` ([#​39035](https://togithub.com/mui/material-ui/issues/39035)) [@​Janpot](https://togithub.com/Janpot) - \[docs-infra] Fix code removal in table of content ([#​39165](https://togithub.com/mui/material-ui/issues/39165)) [@​alexfauquette](https://togithub.com/alexfauquette) - \[docs-infra] Improve callouts design ([#​39084](https://togithub.com/mui/material-ui/issues/39084)) [@​danilo-leal](https://togithub.com/danilo-leal) - \[docs-infra] Fix key warning in Base UI Slider slots section ([#​38954](https://togithub.com/mui/material-ui/issues/38954)) [@​ZeeshanTamboli](https://togithub.com/ZeeshanTamboli) - \[docs-infra] Fix error when redirecting to the root page ([#​38451](https://togithub.com/mui/material-ui/issues/38451)) [@​maheshguntur](https://togithub.com/maheshguntur) - \[docs-infra] Open demo crash in the right repository ([#​39006](https://togithub.com/mui/material-ui/issues/39006)) [@​oliviertassinari](https://togithub.com/oliviertassinari) - \[test] Split the test package ([#​39061](https://togithub.com/mui/material-ui/issues/39061)) [@​michaldudak](https://togithub.com/michaldudak) - \[website] React Engineer - xCharts role ([#​38976](https://togithub.com/mui/material-ui/issues/38976)) [@​DanailH](https://togithub.com/DanailH) - \[website] Improve the highlighter component colors ([#​39087](https://togithub.com/mui/material-ui/issues/39087)) [@​danilo-leal](https://togithub.com/danilo-leal) - \[website] Fix Pricing page row hover ([#​39097](https://togithub.com/mui/material-ui/issues/39097)) [@​danilo-leal](https://togithub.com/danilo-leal) - \[website] Fix typo with straight quote [@​oliviertassinari](https://togithub.com/oliviertassinari) - \[website] Sync about page [@​oliviertassinari](https://togithub.com/oliviertassinari) - \[website] Update the about page ([#​38733](https://togithub.com/mui/material-ui/issues/38733)) [@​danilo-leal](https://togithub.com/danilo-leal) - \[website] Small fixes on the X marketing page ([#​38975](https://togithub.com/mui/material-ui/issues/38975)) [@​flaviendelangle](https://togithub.com/flaviendelangle) - \[website] Add stray design tweaks to the X page ([#​38589](https://togithub.com/mui/material-ui/issues/38589)) [@​danilo-leal](https://togithub.com/danilo-leal) All contributors of this release in alphabetical order: [@​alexfauquette](https://togithub.com/alexfauquette), [@​alisasanib](https://togithub.com/alisasanib), [@​anle9650](https://togithub.com/anle9650), [@​anon-phantom](https://togithub.com/anon-phantom), [@​DanailH](https://togithub.com/DanailH), [@​danilo-leal](https://togithub.com/danilo-leal), [@​DiegoAndai](https://togithub.com/DiegoAndai), [@​flaviendelangle](https://togithub.com/flaviendelangle), [@​gitstart](https://togithub.com/gitstart), [@​Janpot](https://togithub.com/Janpot), [@​jergason](https://togithub.com/jergason), [@​maheshguntur](https://togithub.com/maheshguntur), [@​michaldudak](https://togithub.com/michaldudak), [@​mikailaread](https://togithub.com/mikailaread), [@​mj12albert](https://togithub.com/mj12albert), [@​mnajdova](https://togithub.com/mnajdova), [@​oliviertassinari](https://togithub.com/oliviertassinari), [@​sai6855](https://togithub.com/sai6855), [@​Studio384](https://togithub.com/Studio384), [@​tebersefa](https://togithub.com/tebersefa), [@​vadimka123](https://togithub.com/vadimka123), [@​zanivan](https://togithub.com/zanivan), [@​ZeeshanTamboli](https://togithub.com/ZeeshanTamboli) </details> <details> <summary>mui/mui-x (@​mui/x-date-pickers)</summary> ### [`v6.16.0`](https://togithub.com/mui/mui-x/blob/HEAD/CHANGELOG.md#6160) [Compare Source](https://togithub.com/mui/mui-x/compare/v6.15.0...v6.16.0) *Sep 29, 2023* We'd like to offer a big thanks to the 9 contributors who made this release possible. Here are some highlights ✨: - 🎁 Add a clearable behavior to all the single input pickers and fields ([#​9095](https://togithub.com/mui/mui-x/issues/9095)) [@​noraleonte](https://togithub.com/noraleonte) The pickers and fields now have an out-of-the box implementation for clearing the field value. You can see the documentation for this behavior on the [Date Picker documentation](https://mui.com/x/react-date-pickers/date-picker/#clearing-the-value). <img width="380" alt="Clearable behavior" src="https://github.com/mui/mui-x/assets/72460825/e4a66169-83b5-4579-b9f6-6e15bb528411"> - 💫 Add Date Picker customization playground ([#​9581](https://togithub.com/mui/mui-x/issues/9581)) [@​noraleonte](https://togithub.com/noraleonte) You can play around with style customization options on the [Date Picker documentation](https://mui.com/x/react-date-pickers/date-picker/#customization). We are thrilled to hear your feedback about this functionality! - 🚀 Fix header filters menu auto closing on render ([#​10483](https://togithub.com/mui/mui-x/issues/10483)) [@​MBilalShafi](https://togithub.com/MBilalShafi) - 🎯 Fix column headers scroll when theme scoping is used ([#​10437](https://togithub.com/mui/mui-x/issues/10437)) [@​cherniavskii](https://togithub.com/cherniavskii) - 🌍 Improve Russian (ru-RU) locale on the data grid - 🐞 Bugfixes - 📚 Documentation improvements ##### Data Grid ##### `@mui/[email protected]` - \[DataGrid] Fix column headers scroll when theme scoping is used ([#​10437](https://togithub.com/mui/mui-x/issues/10437)) [@​cherniavskii](https://togithub.com/cherniavskii) - \[DataGrid] Rename `global` to `globalScope` due to Jest issue ([#​10470](https://togithub.com/mui/mui-x/issues/10470)) [@​romgrk](https://togithub.com/romgrk) - \[l10n] Improve Russian (ru-RU) locale ([#​10464](https://togithub.com/mui/mui-x/issues/10464) and [#​10407](https://togithub.com/mui/mui-x/issues/10407)) [@​NKodos](https://togithub.com/NKodos) ##### `@mui/[email protected]` [](https://mui.com/r/x-pro-svg-link "Pro plan") Same changes as in `@mui/[email protected]`, plus: - \[DataGridPro] Fix header filters menu auto closing on render ([#​10483](https://togithub.com/mui/mui-x/issues/10483)) [@​MBilalShafi](https://togithub.com/MBilalShafi) ##### `@mui/[email protected]` [](https://mui.com/r/x-premium-svg-link "Premium plan") Same changes as in `@mui/[email protected]`. ##### Date Pickers ##### `@mui/[email protected]` - \[pickers] Add warning to `shouldDisableDate` validation ([#​10502](https://togithub.com/mui/mui-x/issues/10502)) [@​michelengelen](https://togithub.com/michelengelen) - \[pickers] Implement `clearable` field behavior ([#​9095](https://togithub.com/mui/mui-x/issues/9095)) [@​noraleonte](https://togithub.com/noraleonte) - \[pickers] Refactor `dayOfWeekFormatter` ([#​10345](https://togithub.com/mui/mui-x/issues/10345)) [@​michelengelen](https://togithub.com/michelengelen) ##### `@mui/[email protected]` [](https://mui.com/r/x-pro-svg-link "Pro plan") Same changes as in `@mui/[email protected]`. ##### Charts / `@mui/[email protected]` - \[charts] Share upfront future Pro features ([#​10465](https://togithub.com/mui/mui-x/issues/10465)) [@​oliviertassinari](https://togithub.com/oliviertassinari) ##### Tree View / `@mui/[email protected]` - \[TreeView] Do not try to focus a collapsed node when re-focusing the TreeView ([#​10422](https://togithub.com/mui/mui-x/issues/10422)) [@​flaviendelangle](https://togithub.com/flaviendelangle) - \[TreeView] Fix the typing of the `Multiple` generic ([#​10478](https://togithub.com/mui/mui-x/issues/10478)) [@​flaviendelangle](https://togithub.com/flaviendelangle) ##### Docs - \[docs] Correct the typo in data grid api docs ([#​10477](https://togithub.com/mui/mui-x/issues/10477)) [@​MBilalShafi](https://togithub.com/MBilalShafi) - \[docs] Add customization playground ([#​9581](https://togithub.com/mui/mui-x/issues/9581)) [@​noraleonte](https://togithub.com/noraleonte) - \[docs] Fix Tree View product ID ([#​10428](https://togithub.com/mui/mui-x/issues/10428)) [@​oliviertassinari](https://togithub.com/oliviertassinari) - \[docs] Fix demo crashing when all rows are deleted ([#​10438](https://togithub.com/mui/mui-x/issues/10438)) [@​cherniavskii](https://togithub.com/cherniavskii) - \[docs] Fix mobile scrollbar column resize ([#​10455](https://togithub.com/mui/mui-x/issues/10455)) [@​oliviertassinari](https://togithub.com/oliviertassinari) - \[docs] Fix usage of `GridRenderCellParams` interface ([#​10435](https://togithub.com/mui/mui-x/issues/10435)) [@​cherniavskii](https://togithub.com/cherniavskii) ##### Core - \[core] Fix typo in header data grid quick filter [@​oliviertassinari](https://togithub.com/oliviertassinari) - \[core] Group D3 renovate PRs ([#​10480](https://togithub.com/mui/mui-x/issues/10480)) [@​flaviendelangle](https://togithub.com/flaviendelangle) - \[core] Link the priority support page ([#​10495](https://togithub.com/mui/mui-x/issues/10495)) [@​michelengelen](https://togithub.com/michelengelen) - \[core] Move the pickers describes to the test utils folder ([#​10490](https://togithub.com/mui/mui-x/issues/10490)) [@​flaviendelangle](https://togithub.com/flaviendelangle) - \[core] Priority Support casing normalization [@​oliviertassinari](https://togithub.com/oliviertassinari) - \[core] Remove automated DataGrid performance tests ([#​10414](https://togithub.com/mui/mui-x/issues/10414)) [@​romgrk](https://togithub.com/romgrk) - \[core] Sync `prism-okaidia.css` with docs-infra [@​oliviertassinari](https://togithub.com/oliviertassinari) - \[core] Update issue actions & templates ([#​10375](https://togithub.com/mui/mui-x/issues/10375)) [@​romgrk](https://togithub.com/romgrk) - \[core] Update release guide ([#​10468](https://togithub.com/mui/mui-x/issues/10468)) [@​DanailH](https://togithub.com/DanailH) </details> <details> <summary>reduxjs/redux-toolkit (@​reduxjs/toolkit)</summary> ### [`v1.9.6`](https://togithub.com/reduxjs/redux-toolkit/releases/tag/v1.9.6) [Compare Source](https://togithub.com/reduxjs/redux-toolkit/compare/v1.9.5...v1.9.6) This bugfix release adds a new dev-mode middleware to catch accidentally dispatching an action creator, adds a new listener middleware option around waiting for forks, adds a new option to update provided tags when `updateQueryData` is used, reworks internal types to better handle uses with TS declaration output, and fixes a variety of small issues. ##### Changelog ##### Action Creator Dev Check Middleware RTK already includes dev-mode middleware that check for the common mistakes of accidentally mutating state and putting non-serializable values into state or actions. Over the years we've also seen a semi-frequent error where users accidentally pass an action creator reference to `dispatch`, instead of *calling* it and dispatching the action it returns. We've added another dev-mode middleware that specifically catches this error and warns about it. ##### Additional Options The listener middleware's `listenerApi.fork()` method now has an optional `autoJoin` flag that can be used to keep the effect from finishing until all active forked tasks have completed. `updateQueryData` now has an `updateProvidedTags` option that will force a recalculation of that endpoint's provided tags. It currently defaults to `false`, and we'll likely turn that to `true` in the next major. ##### Other Fixes The `builder.addCase` method now throws an error if a `type` string is empty. `fetchBaseQuery` now uses an alternate method to clone the original `Request` in order to work around an obscure Chrome bug. The immutability middleware logic was tweaked to avoid a potential stack overflow. ##### Types Changes The internal type imports have been reworked to try to fix "type portability" issues when used in combination with TS declaration outputs. A couple additional types were exported to help with wrapping `createAsyncThunk`. ##### What's Changed - create action creator middleware by [@​EskiMojo14](https://togithub.com/EskiMojo14) in [https://github.com/reduxjs/redux-toolkit/pull/3414](https://togithub.com/reduxjs/redux-toolkit/pull/3414) - Implement auto fork joining by [@​ericanderson](https://togithub.com/ericanderson) in [https://github.com/reduxjs/redux-toolkit/pull/3407](https://togithub.com/reduxjs/redux-toolkit/pull/3407) - types: make it easier to wrap createAsyncThunk by [@​shrouxm](https://togithub.com/shrouxm) in [https://github.com/reduxjs/redux-toolkit/pull/3393](https://togithub.com/reduxjs/redux-toolkit/pull/3393) - Fixed Stackoverflow bug if children prop is a ref to root/parent object by [@​cheprasov](https://togithub.com/cheprasov) in [https://github.com/reduxjs/redux-toolkit/pull/3428](https://togithub.com/reduxjs/redux-toolkit/pull/3428) - Fix TransformedResponse type to unwrap promise by [@​EskiMojo14](https://togithub.com/EskiMojo14) in [https://github.com/reduxjs/redux-toolkit/pull/3500](https://togithub.com/reduxjs/redux-toolkit/pull/3500) - Throw error when type is empty in builder.addCase by [@​chawes13](https://togithub.com/chawes13) in [https://github.com/reduxjs/redux-toolkit/pull/3572](https://togithub.com/reduxjs/redux-toolkit/pull/3572) - \[RED-23] fix: Updated type references to resolve portable types issue by [@​tdurnford](https://togithub.com/tdurnford) in [https://github.com/reduxjs/redux-toolkit/pull/3728](https://togithub.com/reduxjs/redux-toolkit/pull/3728) - add option to update provided tags by [@​dutzi](https://togithub.com/dutzi) in [https://github.com/reduxjs/redux-toolkit/pull/3255](https://togithub.com/reduxjs/redux-toolkit/pull/3255) - \[RED-26] Remove Request.clone() usage in fetchBaseQuery by [@​alex-vukov](https://togithub.com/alex-vukov) in [https://github.com/reduxjs/redux-toolkit/pull/3720](https://togithub.com/reduxjs/redux-toolkit/pull/3720) - Try working around TS 4.1 mismatch by [@​markerikson](https://togithub.com/markerikson) in [https://github.com/reduxjs/redux-toolkit/pull/3739](https://togithub.com/reduxjs/redux-toolkit/pull/3739) **Full Changelog**: https://github.com/reduxjs/redux-toolkit/compare/v1.9.5...v1.9.6 </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v6.7.3`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#673-2023-09-25) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.7.2...v6.7.3) **Note:** Version bump only for package [@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v6.7.3`](https://togithub.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#673-2023-09-25) [Compare Source](https://togithub.com/typescript-eslint/typescript-eslint/compare/v6.7.2...v6.7.3) **Note:** Version bump only for package [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>vitejs/vite-plugin-react (@​vitejs/plugin-react)</summary> ### [`v4.1.0`](https://togithub.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#410-2023-09-24) [Compare Source](https://togithub.com/vitejs/vite-plugin-react/compare/v4.0.4...v4.1.0) - Add `@types/babel__cores` to dependencies (fix [#​211](https://togithub.com/vitejs/vite-plugin-react/issues/211)) - Improve build perf when not using Babel plugins by lazy loading `@babel/core` [#​212](https://togithub.com/vitejs/vite-plugin-react/pull/212) - Better invalidation message when an export is added & fix HMR for export of nullish values [#​215](https://togithub.com/vitejs/vite-plugin-react/pull/215) - Include non-dev jsx runtime in optimizeDeps & support HMR for JS files using the non dev runtime [#​224](https://togithub.com/vitejs/vite-plugin-react/pull/224) - The build output now contains a `index.d.cts` file so you don't get types errors when setting `moduleResolution` to `node16` or `nodenext` in your tsconfig (we recommend using `bundler` which is more close to how Vite works) </details> <details> <summary>aws/aws-cdk (aws-cdk)</summary> ### [`v2.99.1`](https://togithub.com/aws/aws-cdk/releases/tag/v2.99.1) [Compare Source](https://togithub.com/aws/aws-cdk/compare/v2.99.0...v2.99.1) ##### Bug Fixes - load time regression ([#​27314](https://togithub.com/aws/aws-cdk/issues/27314)) ([fca5a73](https://togithub.com/aws/aws-cdk/commit/fca5a7344d2e205663873b577d5d91f203dd9d14)) *** #### Alpha modules (2.99.1-alpha.0) ### [`v2.99.0`](https://togithub.com/aws/aws-cdk/releases/tag/v2.99.0) [Compare Source](https://togithub.com/aws/aws-cdk/compare/v2.98.0...v2.99.0) ##### Features - **s3:** specify minimum TLS version ([#​27297](https://togithub.com/aws/aws-cdk/issues/27297)) ([f47d09c](https://togithub.com/aws/aws-cdk/commit/f47d09c08871517f06c1895a5ed262c8e87ee05b)), closes [#​27279](https://togithub.com/aws/aws-cdk/issues/27279) - **synthetics:** graduate to stable 🚀 ([#​27305](https://togithub.com/aws/aws-cdk/issues/27305)) ([dd00d05](https://togithub.com/aws/aws-cdk/commit/dd00d05c07cb3c6efd505e9f7ab577a5eec5070b)) ##### Bug Fixes - **batch:** make `instanceType` optional on multinode jobs ([#​27223](https://togithub.com/aws/aws-cdk/issues/27223)) ([6616026](https://togithub.com/aws/aws-cdk/commit/6616026d3879f0271b7813ed00f0899c666da1e3)), closes [#​27185](https://togithub.com/aws/aws-cdk/issues/27185) *** #### Alpha modules (2.99.0-alpha.0) ##### Features - **apprunner:** add HealthCheckConfiguration property in Service ([#​27029](https://togithub.com/aws/aws-cdk/issues/27029)) ([4e8c9c4](https://togithub.com/aws/aws-cdk/commit/4e8c9c4dfdae690d9f6650bbc57bacdb83dec68c)), closes [#​26972](https://togithub.com/aws/aws-cdk/issues/26972) ##### Bug Fixes - **appconfig:** allow multiple environment monitor roles to be created ([#​27243](https://togithub.com/aws/aws-cdk/issues/27243)) ([9312c97](https://togithub.com/aws/aws-cdk/commit/9312c9763813af4ac6d2be96e78f6aeaefeeb32c)) ### [`v2.98.0`](https://togithub.com/aws/aws-cdk/releases/tag/v2.98.0) [Compare Source](https://togithub.com/aws/aws-cdk/compare/v2.97.1...v2.98.0) ##### Features - update AWS Service Spec ([#​27276](https://togithub.com/aws/aws-cdk/issues/27276)) ([3d9ca8d](https://togithub.com/aws/aws-cdk/commit/3d9ca8dad29e6e6f813ab2340da7639c24ba5494)) - **aws-cdk-lib:** reduce load time of JavaScript library ([#​27217](https://togithub.com/aws/aws-cdk/issues/27217)) ([faffce0](https://togithub.com/aws/aws-cdk/commit/faffce06c3f1d543600f7e8dc430a5105c73ac5a)) ##### Bug Fixes - **rds:** prevent rendering deprecated credentials when creating a database cluster from a snapshot (under feature flag) ([#​27174](https://togithub.com/aws/aws-cdk/issues/27174)) ([1fd22a7](https://togithub.com/aws/aws-cdk/commit/1fd22a7498223ae5d2faf1799056e81be4f71f5c)), closes [#​23815](https://togithub.com/aws/aws-cdk/issues/23815) *** #### Alpha modules (2.98.0-alpha.0) ##### Features - **scheduler:** disable Schedule on creation ([#​27236](https://togithub.com/aws/aws-cdk/issues/27236)) ([193cd3f](https://togithub.com/aws/aws-cdk/commit/193cd3f575974e4058fcec957640a3d28d114fd1)) ### [`v2.97.1`](https://togithub.com/aws/aws-cdk/releases/tag/v2.97.1) [Compare Source](https://togithub.com/aws/aws-cdk/compare/v2.97.0...v2.97.1) ##### Reverts - "feat(core): `Schedule` class" ([#​27284](https://togithub.com/aws/aws-cdk/issues/27284)) ([e2fc724](https://togithub.com/aws/aws-cdk/commit/e2fc7240672b5c26394b2fe420531d62fe74189b)), closes [aws/aws-cdk#27105](https://togithub.com/aws/aws-cdk/issues/27105) [#​27259](https://togithub.com/aws/aws-cdk/issues/27259) *** #### Alpha modules (2.97.1-alpha.0) </details> <details> <summary>aws/aws-sdk-js (aws-sdk)</summary> ### [`v2.1467.0`](https://togithub.com/aws/aws-sdk-js/blob/HEAD/CHANGELOG.md#214670) [Compare Source](https://togithub.com/aws/aws-sdk-js/compare/v2.1466.0...v2.1467.0) - feature: Bedrock: Model Invocation logging added to enable or disable logs in customer account. Model listing and description support added. Provisioned Throughput feature added. Custom model support added for creating custom models. Also includes list, and delete functions for custom model. - feature: BedrockRuntime: Run Inference: Added support to run the inference on models. Includes set of APIs for running inference in streaming and non-streaming mode. - feature: Budgets: Update DescribeBudgets and DescribeBudgetNotificationsForAccount MaxResults limit to 1000. - feature: EC2: Adds support for Customer Managed Key encryption for Amazon Verified Access resources - feature: IoTFleetWise: AWS IoT FleetWise now supports encryption through a customer managed AWS KMS key. The PutEncryptionConfiguration and GetEncryptionConfiguration APIs were added. - feature: SageMaker: Online store feature groups supports Standard and InMemory tier storage types for low latency storage for real-time data retrieval. The InMemory tier supports collection types List, Set, and Vector. - feature: SageMakerFeatureStoreRuntime: Feature Store supports read/write of records with collection type features. ### [`v2.1466.0`](https://togithub.com/aws/aws-sdk-js/blob/HEAD/CHANGELOG.md#214660) [Compare Source](https://togithub.com/aws/aws-sdk-js/compare/v2.1465.0...v2.1466.0) - feature: CognitoIdentityServiceProvider: The UserPoolType Status field is no longer used. - feature: Firehose: Features : Adding support for new data ingestion source to Kinesis Firehose - AWS Managed Services Kafka. - feature: Iot: Added support for IoT Rules Engine Kafka Action Headers - feature: Textract: This release adds new feature - Layout to Analyze Document API which can automatically extract layout elements such as titles, paragraphs, headers, section headers, lists, page numbers, footers, table areas, key-value areas and figure areas and order the elements as a human would read. ### [`v2.1465.0`](https://togithub.com/aws/aws-sdk-js/blob/HEAD/CHANGELOG.md#214650) [Compare Source](https://togithub.com/aws/aws-sdk-js/compare/v2.1464.0...v2.1465.0) - feature: AppIntegrations: The Amazon AppIntegrat </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/share.kirschbaum.cloud).
mergify bot
pushed a commit
to SvenKirschbaum/aws-utils
that referenced
this pull request
Oct 1, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | | | lockFileMaintenance | All locks refreshed | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@aws-cdk/aws-apigatewayv2-alpha](https://togithub.com/aws/aws-cdk) | dependencies | minor | [`2.97.0-alpha.0` -> `2.99.1-alpha.0`](https://renovatebot.com/diffs/npm/@aws-cdk%2faws-apigatewayv2-alpha/2.97.0-alpha.0/2.99.1-alpha.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@aws-cdk/aws-apigatewayv2-integrations-alpha](https://togithub.com/aws/aws-cdk) | dependencies | minor | [`2.97.0-alpha.0` -> `2.99.1-alpha.0`](https://renovatebot.com/diffs/npm/@aws-cdk%2faws-apigatewayv2-integrations-alpha/2.97.0-alpha.0/2.99.1-alpha.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@aws-lambda-powertools/logger](https://togithub.com/aws-powertools/powertools-lambda-typescript/tree/main/packages/logger#readme) ([source](https://togithub.com/aws-powertools/powertools-lambda-typescript)) | dependencies | minor | [`1.13.1` -> `1.14.0`](https://renovatebot.com/diffs/npm/@aws-lambda-powertools%2flogger/1.13.1/1.14.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@aws-lambda-powertools/tracer](https://togithub.com/aws-powertools/powertools-lambda-typescript/tree/main/packages/tracer#readme) ([source](https://togithub.com/aws-powertools/powertools-lambda-typescript)) | dependencies | minor | [`1.13.1` -> `1.14.0`](https://renovatebot.com/diffs/npm/@aws-lambda-powertools%2ftracer/1.13.1/1.14.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@aws-sdk/client-secrets-manager](https://togithub.com/aws/aws-sdk-js-v3/tree/main/clients/client-secrets-manager) ([source](https://togithub.com/aws/aws-sdk-js-v3)) | dependencies | minor | [`3.418.0` -> `3.421.0`](https://renovatebot.com/diffs/npm/@aws-sdk%2fclient-secrets-manager/3.418.0/3.421.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@trautonen/cdk-dns-validated-certificate](https://togithub.com/trautonen/cdk-dns-validated-certificate) | dependencies | patch | [`0.0.22` -> `0.0.23`](https://renovatebot.com/diffs/npm/@trautonen%2fcdk-dns-validated-certificate/0.0.22/0.0.23) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) | devDependencies | minor | [`20.6.4` -> `20.8.0`](https://renovatebot.com/diffs/npm/@types%2fnode/20.6.4/20.8.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [aws-cdk](https://togithub.com/aws/aws-cdk) | devDependencies | minor | [`2.97.0` -> `2.99.1`](https://renovatebot.com/diffs/npm/aws-cdk/2.97.0/2.99.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [aws-cdk-lib](https://togithub.com/aws/aws-cdk) | dependencies | minor | [`2.97.0` -> `2.99.1`](https://renovatebot.com/diffs/npm/aws-cdk-lib/2.97.0/2.99.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [esbuild](https://togithub.com/evanw/esbuild) | devDependencies | patch | [`0.19.3` -> `0.19.4`](https://renovatebot.com/diffs/npm/esbuild/0.19.3/0.19.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | 🔧 This Pull Request updates lock files to use the latest dependency versions. --- ### Release Notes <details> <summary>aws-powertools/powertools-lambda-typescript (@​aws-lambda-powertools/logger)</summary> ### [`v1.14.0`](https://togithub.com/aws-powertools/powertools-lambda-typescript/blob/HEAD/CHANGELOG.md#1140-2023-09-29) [Compare Source](https://togithub.com/aws-powertools/powertools-lambda-typescript/compare/v1.13.1...v1.14.0) ##### Features - **idempotency:** add idempotency decorator ([#​1723](https://togithub.com/aws-powertools/powertools-lambda-typescript/issues/1723)) ([d138673](https://togithub.com/aws-powertools/powertools-lambda-typescript/commit/d138673a33ff31f40b225dc046b2ff8258d0a97d)) - **layers:** add `arm64` to integration test matrix ([#​1720](https://togithub.com/aws-powertools/powertools-lambda-typescript/issues/1720)) ([61ad5ac](https://togithub.com/aws-powertools/powertools-lambda-typescript/commit/61ad5ac3bcf7742684aeec28553ec294696f3301)) - **tracer:** add try/catch logic to decorator and middleware close ([#​1716](https://togithub.com/aws-powertools/powertools-lambda-typescript/issues/1716)) ([be16b59](https://togithub.com/aws-powertools/powertools-lambda-typescript/commit/be16b599b8023f95572234fb222ea70aea5b3f17)) #### [1.13.1](https://togithub.com/aws-powertools/powertools-lambda-typescript/compare/v1.13.0...v1.13.1) (2023-09-21) ##### Bug Fixes - **maintenance:** remove upper peer dependency Middy ([#​1705](https://togithub.com/aws-powertools/powertools-lambda-typescript/issues/1705)) ([df21ec8](https://togithub.com/aws-powertools/powertools-lambda-typescript/commit/df21ec8761b1be511c13c28fedd41bf0e2851061)) </details> <details> <summary>aws/aws-sdk-js-v3 (@​aws-sdk/client-secrets-manager)</summary> ### [`v3.421.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-secrets-manager/CHANGELOG.md#34210-2023-09-27) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.418.0...v3.421.0) **Note:** Version bump only for package [@​aws-sdk/client-secrets-manager](https://togithub.com/aws-sdk/client-secrets-manager) </details> <details> <summary>trautonen/cdk-dns-validated-certificate (@​trautonen/cdk-dns-validated-certificate)</summary> ### [`v0.0.23`](https://togithub.com/trautonen/cdk-dns-validated-certificate/releases/tag/v0.0.23) [Compare Source](https://togithub.com/trautonen/cdk-dns-validated-certificate/compare/v0.0.22...v0.0.23) ##### [0.0.23](https://togithub.com/trautonen/cdk-dns-validated-certificate/compare/v0.0.22...v0.0.23) (2023-09-25) </details> <details> <summary>aws/aws-cdk (aws-cdk)</summary> ### [`v2.99.1`](https://togithub.com/aws/aws-cdk/releases/tag/v2.99.1) [Compare Source](https://togithub.com/aws/aws-cdk/compare/v2.99.0...v2.99.1) ##### Bug Fixes - load time regression ([#​27314](https://togithub.com/aws/aws-cdk/issues/27314)) ([fca5a73](https://togithub.com/aws/aws-cdk/commit/fca5a7344d2e205663873b577d5d91f203dd9d14)) *** #### Alpha modules (2.99.1-alpha.0) ### [`v2.99.0`](https://togithub.com/aws/aws-cdk/releases/tag/v2.99.0) [Compare Source](https://togithub.com/aws/aws-cdk/compare/v2.98.0...v2.99.0) ##### Features - **s3:** specify minimum TLS version ([#​27297](https://togithub.com/aws/aws-cdk/issues/27297)) ([f47d09c](https://togithub.com/aws/aws-cdk/commit/f47d09c08871517f06c1895a5ed262c8e87ee05b)), closes [#​27279](https://togithub.com/aws/aws-cdk/issues/27279) - **synthetics:** graduate to stable 🚀 ([#​27305](https://togithub.com/aws/aws-cdk/issues/27305)) ([dd00d05](https://togithub.com/aws/aws-cdk/commit/dd00d05c07cb3c6efd505e9f7ab577a5eec5070b)) ##### Bug Fixes - **batch:** make `instanceType` optional on multinode jobs ([#​27223](https://togithub.com/aws/aws-cdk/issues/27223)) ([6616026](https://togithub.com/aws/aws-cdk/commit/6616026d3879f0271b7813ed00f0899c666da1e3)), closes [#​27185](https://togithub.com/aws/aws-cdk/issues/27185) *** #### Alpha modules (2.99.0-alpha.0) ##### Features - **apprunner:** add HealthCheckConfiguration property in Service ([#​27029](https://togithub.com/aws/aws-cdk/issues/27029)) ([4e8c9c4](https://togithub.com/aws/aws-cdk/commit/4e8c9c4dfdae690d9f6650bbc57bacdb83dec68c)), closes [#​26972](https://togithub.com/aws/aws-cdk/issues/26972) ##### Bug Fixes - **appconfig:** allow multiple environment monitor roles to be created ([#​27243](https://togithub.com/aws/aws-cdk/issues/27243)) ([9312c97](https://togithub.com/aws/aws-cdk/commit/9312c9763813af4ac6d2be96e78f6aeaefeeb32c)) ### [`v2.98.0`](https://togithub.com/aws/aws-cdk/releases/tag/v2.98.0) [Compare Source](https://togithub.com/aws/aws-cdk/compare/v2.97.1...v2.98.0) ##### Features - update AWS Service Spec ([#​27276](https://togithub.com/aws/aws-cdk/issues/27276)) ([3d9ca8d](https://togithub.com/aws/aws-cdk/commit/3d9ca8dad29e6e6f813ab2340da7639c24ba5494)) - **aws-cdk-lib:** reduce load time of JavaScript library ([#​27217](https://togithub.com/aws/aws-cdk/issues/27217)) ([faffce0](https://togithub.com/aws/aws-cdk/commit/faffce06c3f1d543600f7e8dc430a5105c73ac5a)) ##### Bug Fixes - **rds:** prevent rendering deprecated credentials when creating a database cluster from a snapshot (under feature flag) ([#​27174](https://togithub.com/aws/aws-cdk/issues/27174)) ([1fd22a7](https://togithub.com/aws/aws-cdk/commit/1fd22a7498223ae5d2faf1799056e81be4f71f5c)), closes [#​23815](https://togithub.com/aws/aws-cdk/issues/23815) *** #### Alpha modules (2.98.0-alpha.0) ##### Features - **scheduler:** disable Schedule on creation ([#​27236](https://togithub.com/aws/aws-cdk/issues/27236)) ([193cd3f](https://togithub.com/aws/aws-cdk/commit/193cd3f575974e4058fcec957640a3d28d114fd1)) ### [`v2.97.1`](https://togithub.com/aws/aws-cdk/releases/tag/v2.97.1) [Compare Source](https://togithub.com/aws/aws-cdk/compare/v2.97.0...v2.97.1) ##### Reverts - "feat(core): `Schedule` class" ([#​27284](https://togithub.com/aws/aws-cdk/issues/27284)) ([e2fc724](https://togithub.com/aws/aws-cdk/commit/e2fc7240672b5c26394b2fe420531d62fe74189b)), closes [aws/aws-cdk#27105](https://togithub.com/aws/aws-cdk/issues/27105) [#​27259](https://togithub.com/aws/aws-cdk/issues/27259) *** #### Alpha modules (2.97.1-alpha.0) </details> <details> <summary>evanw/esbuild (esbuild)</summary> ### [`v0.19.4`](https://togithub.com/evanw/esbuild/blob/HEAD/CHANGELOG.md#0194) [Compare Source](https://togithub.com/evanw/esbuild/compare/v0.19.3...v0.19.4) - Fix printing of JavaScript decorators in tricky cases ([#​3396](https://togithub.com/evanw/esbuild/issues/3396)) This release fixes some bugs where esbuild's pretty-printing of JavaScript decorators could incorrectly produced code with a syntax error. The problem happened because esbuild sometimes substitutes identifiers for other expressions in the pretty-printer itself, but the decision about whether to wrap the expression or not didn't account for this. Here are some examples: ```js // Original code import { constant } from './constants.js' import { imported } from 'external' import { undef } from './empty.js' class Foo { @​constant() @​imported() @​undef() foo } // Old output (with --bundle --format=cjs --packages=external --minify-syntax) var import_external = require("external"); var Foo = class { @​123() @​(0, import_external.imported)() @​(void 0)() foo; }; // New output (with --bundle --format=cjs --packages=external --minify-syntax) var import_external = require("external"); var Foo = class { @​(123()) @​((0, import_external.imported)()) @​((void 0)()) foo; }; ``` - Allow pre-release versions to be passed to `target` ([#​3388](https://togithub.com/evanw/esbuild/issues/3388)) People want to be able to pass version numbers for unreleased versions of node (which have extra stuff after the version numbers) to esbuild's `target` setting and have esbuild do something reasonable with them. These version strings are of course not present in esbuild's internal feature compatibility table because an unreleased version has not been released yet (by definition). With this release, esbuild will now attempt to accept these version strings passed to `target` and do something reasonable with them. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/aws-utils).
|
Having timezone in CRON was useful for ECS scheduled tasks as well. Ever since this change, that feature is broken. I'd appreciate if timezone can be added to ecs.scaleOnSchedule |
This was referenced Dec 5, 2023
1 task
mergify bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
Closes #22645 Closes #27754 Spiritual successor of #27052 Somewhat related to #21181 but that might be another PR down the road. @pahud ✋ Please review. I'm not particularly fond of how `aws-autoscaling` module ([here](https://github.com/aws/aws-cdk/blob/256cca4017a80f8643c5f5a5999a2ce0383eebf0/packages/aws-cdk-lib/aws-autoscaling/lib/scheduled-action.ts#L21)) is not using `cdk.TimeZone` class, hence why used it in this PR instead. I think we should we change `aws-autoscaling` implementation to do the same? It would be a breaking change... and most likely a brand new PR. LMK what you think. ✌️ Also, I may be slightly OCD but I kinda like better `timezone` vs `timeZone`, but I went with latter one to follow what `aws-autoscaling` did. cc-ing @kaizencc for his input too 🙌 ... possibly related to #27105 ### Reason for this change Timezones have been supported in `AWS::ApplicationAutoScaling::ScalableTarget ScheduledAction` for a while now. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-applicationautoscaling-scalabletarget-scheduledaction.html#cfn-applicationautoscaling-scalabletarget-scheduledaction-timezone ### Description of changes Just added the support for `timezones` in `scalableTarget.scaleOnSchedule` ### Description of how you validated changes Added unit tests for this feature. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
GavinZZ
pushed a commit
that referenced
this pull request
Feb 22, 2024
](https://renovatebot.com){kind=link}
Closes #22645 Closes #27754 Spiritual successor of #27052 Somewhat related to #21181 but that might be another PR down the road. @pahud ✋ Please review. I'm not particularly fond of how `aws-autoscaling` module ([here](https://github.com/aws/aws-cdk/blob/256cca4017a80f8643c5f5a5999a2ce0383eebf0/packages/aws-cdk-lib/aws-autoscaling/lib/scheduled-action.ts#L21)) is not using `cdk.TimeZone` class, hence why used it in this PR instead. I think we should we change `aws-autoscaling` implementation to do the same? It would be a breaking change... and most likely a brand new PR. LMK what you think. ✌️ Also, I may be slightly OCD but I kinda like better `timezone` vs `timeZone`, but I went with latter one to follow what `aws-autoscaling` did. cc-ing @kaizencc for his input too 🙌 ... possibly related to #27105 ### Reason for this change Timezones have been supported in `AWS::ApplicationAutoScaling::ScalableTarget ScheduledAction` for a while now. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-applicationautoscaling-scalabletarget-scheduledaction.html#cfn-applicationautoscaling-scalabletarget-scheduledaction-timezone ### Description of changes Just added the support for `timezones` in `scalableTarget.scaleOnSchedule` ### Description of how you validated changes Added unit tests for this feature. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My latest attempt at schedule unification across modules.
The following modules use a version of schedule, which this PR aims to unify:
The idea is to have a single source of truth,
core.Schedulethat is exposed and meant to be extended by modules that use a schedule. This is to avoid breaking changes -- every module that currently exports a schedule class continues to do so. Each module can customize their schedule class to its liking, for example, whether or not to supportschedule.atorcronOptions.timeZone.This PR will fix inconsistencies like:
backup.scheduleExpressiondepending onevents.Schedule, which is semi-deprecated by the Events team (they want people to use the Schedule class inaws-scheduler-alpha).aws-scheduler-alphadepending onevents.Scheduleas well.backup.scheduleExpressionallowingschedule.rate(duration)to be specified (synth-time error) when we know that backup schedules only can be cron expressions.timeZoneproperty in all instances of schedulestimeZoneproperty existing directly on a construct when it only pertains tocronexpressions. This is an anomaly because we typically do not want construct-level properties to only be impactful depending on other properties. [See superseded PRs]Challenges:
core.Scheduleonly exposingprotectedAPIs, which are then picked by the consuming modules to be exposed aspublic.cronexpressions accepted. I do some magic inaws-autoscalingto get the cron expression returned there to be as expected.Supersedes #27052 and #27012
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license