Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] feat: Support runtime metrics #1306

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

adebayor123
Copy link

@adebayor123 adebayor123 commented Aug 16, 2024

Relevant PR:

Description of the issue

ApplicationSignals is expanding the set of monitored metrics to include runtime metrics.

Description of changes

This pull request contains changes required to support runtime metrics in CWAgent for ApplicationSignals. To enable the change, we are introducing a new processor, metrictransformprocessor, and expanding the exporter config to handle JVM and Python runtime metrics.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

make test & manual testing

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@adebayor123 adebayor123 requested a review from a team as a code owner August 16, 2024 19:52
@adebayor123 adebayor123 changed the title feat: Add runtime metrics to AppSignals exporter config [DRAFT]feat: Add runtime metrics to AppSignals exporter config Aug 16, 2024
@adebayor123 adebayor123 marked this pull request as draft August 16, 2024 19:56
@adebayor123 adebayor123 changed the title [DRAFT]feat: Add runtime metrics to AppSignals exporter config feat: Add runtime metrics to AppSignals exporter config Aug 16, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

This PR was marked stale due to lack of activity.

@github-actions github-actions bot added the Stale label Sep 3, 2024
@adebayor123 adebayor123 changed the title feat: Add runtime metrics to AppSignals exporter config feat: Support runtime metrics Sep 4, 2024
@github-actions github-actions bot removed the Stale label Sep 5, 2024
Copy link
Collaborator

@bjrara bjrara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please evaluate whether to use mean or sum in the aggregation_type.

@adebayor123 adebayor123 changed the title feat: Support runtime metrics [DO NOT MERGE] feat: Support runtime metrics Sep 18, 2024
@adebayor123 adebayor123 marked this pull request as ready for review September 18, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants