Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support runtime metrics #229

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

adebayor123
Copy link
Contributor

@adebayor123 adebayor123 commented Sep 10, 2024

Relevant PR:

Description of changes:
As part of supporting runtime metrics for Application Signals, we need a mechanism to allow customers to disable runtime-metrics for Addons. This PR creates a new field under manager, autoInstrumentationApplicationSignals that will be used in the cloudwatch-agent-operator to disable runtime-metrics.

E2E Testing

When runtime is set to false:

--auto-instrumentation-config={"dotnet":{"limits":{"cpu":"500m","memory":"128Mi"},"requests":{"cpu":"50m","memory":"128Mi"}},"java":{"limits":{"cpu":"500m","memory":"64Mi"},"requests":{"cpu":"50m","memory":"64Mi"},"runtime":{"enabled":false}},"nodejs":{"limits":{"cpu":"500m","memory":"128Mi"},"requests":{"cpu":"50m","memory":"128Mi"}},"python":{"limits":{"cpu":"500m","memory":"32Mi"},"requests":{"cpu":"50m","memory":"32Mi"},"runtime":{"enabled":false}}}

The namespace level configuration is set as:

OTEL_AWS_APPLICATION_SIGNALS_RUNTIME_ENABLED=false

When runtime is set to true:

--auto-instrumentation-config={"dotnet":{"limits":{"cpu":"500m","memory":"128Mi"},"requests":{"cpu":"50m","memory":"128Mi"}},"java":{"limits":{"cpu":"500m","memory":"64Mi"},"requests":{"cpu":"50m","memory":"64Mi"},"runtime":{"enabled":true}},"nodejs":{"limits":{"cpu":"500m","memory":"128Mi"},"requests":{"cpu":"50m","memory":"128Mi"}},"python":{"limits":{"cpu":"500m","memory":"32Mi"},"requests":{"cpu":"50m","memory":"32Mi"},"runtime":{"enabled":true}}}

The namespace level configuration is set as:

OTEL_AWS_APPLICATION_SIGNALS_RUNTIME_ENABLED=true

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@adebayor123 adebayor123 changed the title feat: Support runtime metrics [DO NOT MERGE] feat: Support runtime metrics Sep 18, 2024
@adebayor123 adebayor123 marked this pull request as ready for review September 18, 2024 20:36
@adebayor123 adebayor123 changed the title [DO NOT MERGE] feat: Support runtime metrics feat: Support runtime metrics Oct 23, 2024
sky333999
sky333999 previously approved these changes Oct 23, 2024
jefchien
jefchien previously approved these changes Oct 24, 2024
main.go Outdated Show resolved Hide resolved
@jefchien jefchien merged commit 5a99777 into aws:main Oct 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants