Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Velero addon to v5.x #287

Open
bryantbiggs opened this issue Oct 31, 2023 · 3 comments
Open

Update Velero addon to v5.x #287

bryantbiggs opened this issue Oct 31, 2023 · 3 comments
Labels
BREAKING CHANGE enhancement New feature or request
Milestone

Comments

@bryantbiggs
Copy link
Contributor

bryantbiggs commented Oct 31, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

What is the outcome that you are trying to reach?

Describe the solution you would like

  • Updated Velero to the latest major version. Since this is a major version change for the chart, there is most likely breaking changes to the values/schema used

Describe alternatives you have considered

Additional context

chart_version = try(var.velero.chart_version, "3.2.0") # TODO - 4.0.0 is out

@bryantbiggs bryantbiggs added this to the v2.0 milestone Oct 31, 2023
@csantanapr csantanapr changed the title Update Velero addon to v4.x Update Velero addon to v5.x Nov 1, 2023
@csantanapr
Copy link
Contributor

csantanapr commented Nov 1, 2023

@bryantbiggs velero latest chart is 5.1.2 not 4.0
To use 5.x here is the new structure of the helm values compatible with v5.x

This is already supported in gitops-bridge we need equivalent in addons v2.0
https://github.com/aws-samples/eks-blueprints-add-ons/blob/main/argocd/bootstrap/control-plane/addons/aws/addons-aws-oss-velero-appset.yaml#L60-L85

            values: |
              configuration:
                backupStorageLocation:
                - name: default
                  provider: aws
                  prefix: {{metadata.annotations.velero_backup_s3_bucket_prefix}}
                  bucket: {{metadata.annotations.velero_backup_s3_bucket_name}}
                  config:
                    region: {{metadata.annotations.aws_region}}
                volumeSnapshotLocation:
                - name: default
                  provider: aws
                  config:
                    region: {{metadata.annotations.aws_region}}
              serviceAccount:
                server:
                  name: {{metadata.annotations.velero_service_account}}
                  annotations:
                    eks.amazonaws.com/role-arn: {{metadata.annotations.velero_iam_role_arn}}
              initContainers:
              - name: velero-plugin-for-aws
                image: velero/velero-plugin-for-aws:v1.7.1
                imagePullPolicy: IfNotPresent
                volumeMounts:
                  - mountPath: /target
                    name: plugins

@github-actions github-actions bot added the stale label Dec 11, 2023
@bryantbiggs bryantbiggs removed the stale label Dec 11, 2023
@aws-ia aws-ia deleted a comment from github-actions bot Dec 11, 2023
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Jan 11, 2024
@askulkarni2 askulkarni2 added enhancement New feature or request and removed stale labels Jan 11, 2024
@Hokwang
Copy link

Hokwang commented Jan 16, 2024

@bryantbiggs Hi, when is the v2.0 target date ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants