Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Looking for PHP programmers #51

Open
avs-code opened this issue May 1, 2018 · 19 comments
Open

Looking for PHP programmers #51

avs-code opened this issue May 1, 2018 · 19 comments

Comments

@avs-code
Copy link
Owner

avs-code commented May 1, 2018

A web programmer is necessary to finish the project

@avs-code avs-code changed the title looking for PHP programmers Looking for PHP programmers May 1, 2018
@Simracer2018
Copy link

OK. I'll also check if I can find one!

@rearley
Copy link
Contributor

rearley commented Nov 22, 2018

I'll take a look around and see if I can help out. Been looking for a project to contribute to.

@Synthese
Copy link

Am also looking for a project where I can work with. However, I have problems with English, so I am not so good.
I also do not know Github so well. I am also willing to learn something in spite of my age. I look at it all the time. If I can help I will do it.

@avs-code
Copy link
Owner Author

Hello, thanks for joining the project. English is not my native language either, and my programming skills are limited. Thanks again.

@Synthese
Copy link

Can I change my fork without changing the original data? Or is it like that when I change in my fork what he makes it pure in the original data ??
Thanks for being part of it, I learned php a long time ago and am working hard on the new version of Php7.2, but I still have some big problems with the classes.
First, I want to change the structure of the data with me. Create folder move data and then adjust the files again. Think with the design could possibly solve better synonymous. but more on that later, me first is important that changes only affect my Fork.
LG

@rearley
Copy link
Contributor

rearley commented Nov 23, 2018

Synthese: You can change anything in your fork and nothing in this repo will be changed until you do a pull request and it is merged into the main repo.

I would like to add composer and restructure the application to make it easier to maintain and update without making it harder for the end user to install/upgrade their version.

@Synthese
Copy link

rearley: Yes that would be useful, I have created folders, z.bsp division there are all division data included except for the file for display on the index.
The others are rather for the area Admin here would be to create an area admin or administration to create, and here all data purely.
Since these are processed via the admin. So you can better secure this area.
I have redesigned the homepage design, this is on bootstrap.
Here, however, the design must be adapted in many files.
In terms of multilingualism, I have considered, it would perhaps make sense to create a folder locale and then folders of the language en, de, etc. in these folders then the files that would be responsible for the language, so you could in the script all the text output as integrate locale.

Sorry that so much write, just have a run :)
I can´t edit last Post i hvave Pic from Design see here.
https://drive.google.com/file/d/13f_vmLICmDwfsQ3ATBLvmf6rEBNIr5uy/view?usp=sharing
https://drive.google.com/file/d/1s7UxCJKtJAzeVyOH6j2eeDTsdxPUOhYG/view?usp=sharing

@avs-code
Copy link
Owner Author

Synthese: You can change anything in your fork and nothing in this repo will be changed until you do a pull request and it is merged into the main repo.

I would like to add composer and restructure the application to make it easier to maintain and update without making it harder for the end user to install/upgrade their version.

@rearley Composer is a software like laravel? I have never used one, I would have to learn 😆
Yes, application installation and update isn't friendly to a web admin user. It would be easier with an installer, but it escapes my knowledge.

In terms of multilingualism, I have considered,

@Synthese It was planned by a previous collaborator as you will have seen in the database, but nothing is done. When I stay alone in the project I reduced my expectations and only hoped to complete what was labeled as high priority (1.1.0 milestone).

from my little experience, I think it is better to make small changes per issue and then push to the repository.
Once a collaborator made a new branch starting from the previous one for every several changes of several things, I was unable to follow the changes to merge into main branch.

This project has a lot of work, is based on an earlier one by 2007 as you can read in my readme.
It is possible that the ideal would have been to make an application from scratch, but since I am not a programmer, everything I have been doing has been to modify and add. 😄
Imgur

Thanks!, I will follow your progress and help in whatever way I can.

@rearley
Copy link
Contributor

rearley commented Nov 23, 2018

Composer is a way to load packages and autoload. It might make it easier and fast to build components without having a re-write in something like Laravel.

@rearley
Copy link
Contributor

rearley commented Nov 23, 2018

I have redesigned the homepage design, this is on bootstrap.
Here, however, the design must be adapted in many files.
In terms of multilingualism, I have considered, it would perhaps make sense to create a folder locale > and then folders of the language en, de, etc. in these folders then the files that would be responsible > for the language, so you could in the script all the text output as integrate locale.

I like bootstrap and the design looks good. What needs to happen to make this a little easier to makes changes is to have a template for the headers and footers that would have the required CSS/JS files. Without doing a re-write, we're going to have to piece it together small parts at a time.

If I can get composer implemented, it might help with building components for each data object ( Race, Division, Season ..etc.. ).

@rearley
Copy link
Contributor

rearley commented Nov 23, 2018

Just to let you know.. I am working on a branch that is not attached to an issue, but cleaning up some code and adding basic git ignore files and getting rid of PHP notices. Also, as a suggestion, I would like to gid rid of the PHP short_open_tags as some servers might not allow it.

@avs-code
Copy link
Owner Author

avs-code commented Nov 23, 2018

ok, then is best copy master branch as "old_master" to update master branch with bootstrap and the others improvements?

The header and footer are in index.php file and header.php

@rearley
Copy link
Contributor

rearley commented Nov 23, 2018

For now I am working on a feature branch on the form version I have.. when I get some things in place and ready for testing I will let you know.

@Synthese
Copy link

That sounds good.
We should also consider making a separate admin area.

If I understood correctly, it should also be possible to organize your own leagues or administer as an admin here.Dazu would then synonymous to the admin overview for editing and register, etc. be designed clearly.

However, we should decide where to start first. I noticed that there is still a table missing in the data bak driver_top_3 if I still have it in my head, it still has to be created.

@Synthese
Copy link

Which PHP version do you use? I use Xampp with php7.2 and Maria and Eclipse. Also have uniform server with php5.5. and 7.1.
But think we should make everything under php7.2 or?

@avs-code
Copy link
Owner Author

I do not know if I'm understanding you (my knowledge of English 😄 ).
Really there are only a admin area, admins are the only people that can add races, divisions, leagues, etc. A normal user only can register his name and avatar.
I think that you are saying create a complete dashboard to admin section with all options and not that separate drop-down menu links, may be cool.

Yes, that table is missing, so data to top drivers is showed using a view feature of mysql (that shared hostings usually don't give access) and getting data from others tables, drivers, races....
I certainly sometimes get lost with the structure of the table. I think it could be simpler, but from my ignorance I don't know. In this case as I say to catch the data of the pilot has to go to several different tables.

In php 7.0 system work fine, in higher versions it would be necessary update the code more, it is quite old (2007). And I've been mixing code here and there...

Let me know in the future if I can help you in something that is not very complex in terms of programming.

@rearley
Copy link
Contributor

rearley commented Nov 24, 2018

Which PHP version do you use? I use Xampp with php7.2 and Maria and Eclipse. Also have uniform server with php5.5. and 7.1.
But think we should make everything under php7.2 or?

The install instructions for the software says 5.6. So any bug fixes you might want to keep at that version and if you want to move to 7+ then that would be a new version of the software. If that is the case, then I would start from scratch with a framework.

I would also think that maybe a slack channel or something for more development geared talks.

@avs-code
Copy link
Owner Author

Guys, there are other proyect using php 7.1+, laravel, and bootstrap with blade. And it will have much more use by users. In case you find it better than this one.. https://github.com/nabeelio/phpvms

@Synthese
Copy link

Synthese commented Dec 1, 2018

@rearley There are now some frameworks, but at the moment I do not know exactly which one would be sinful, whereby I tend to symphony.
Here you can only use the modules you really need.
However, with Symphony I'm still at the beginning, not yet used.
Most of the code I have adapted so far to 7.2, but think that the version still takes a lot more time than yours with php5.6.
My first version with bootstrap looks quite good, although I still have too much php in html.
Do you have a suggestion for me here?
Best Regards

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants