Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global events are called parent first #57

Open
greena13 opened this issue Oct 23, 2017 · 0 comments
Open

Global events are called parent first #57

greena13 opened this issue Oct 23, 2017 · 0 comments

Comments

@greena13
Copy link

Very similar to #56, if two <Shortcut /> tags with the global prop are rendered, one as the child of the other, and they both bind to the same keys, the parent's handler is called before the childs. This is despite the child <Shortcut /> tag being closer to the event target.

IMHO, this is not what people will expect. Users of react and front event developers are accustomed to event handlers defined closer to the target of an event being called first (and being given the chance to stop that event from propagating to handlers attached to parent elements).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant