Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save button icon (floppy disk) issue (on click, doesn't save the record in Safari browser) #3389

Closed
4 of 10 tasks
giedriusr opened this issue Nov 6, 2024 · 1 comment · Fixed by #3397
Closed
4 of 10 tasks
Assignees

Comments

@giedriusr
Copy link

Describe the bug

Image
In Safari 17.5 when I click on the icon, the button starts to blink, but nothing happens. If I click on text or on the button area (avoiding icon) it works as usual.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Add this configuration '...'
  2. Go to any resource page
  3. Click on edit
  4. Click on save button (straight on the floppy disk icon)
  5. The button should hang (blinking)

Expected behavior & Actual behavior

It should save the record and redirect to show page.

Models and resource files

System configuration

Avo version: 3.13.7 (but this behaviour was noticed in previous versions as well)

Rails version: 7.2.2 (also rails 8.0.0.rc2)

Ruby version: 3.3.4 (also 3.3.2)

License type:

  • Community
  • Pro
  • Advanced

Are you using Avo monkey patches, overriding views or view components?

  • Yes. If so, please post code samples.
  • No

Screenshots or screen recordings

Additional context

Impact

  • High impact (It makes my app un-usable.)
  • Medium impact (I'm annoyed, but I'll live.)
  • Low impact (It's really a tiny thing that I could live with.)

Urgency

  • High urgency (I can't continue development without it.)
  • Medium urgency (I found a workaround, but I'd love to have it fixed.)
  • [] Low urgency (It can wait. I just wanted you to know about it.)
@adrianthedev
Copy link
Collaborator

Yup. I see that too.
So weird.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants