Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhino WYSIWYG improvements #3261

Open
pjmuller opened this issue Sep 24, 2024 · 3 comments
Open

Rhino WYSIWYG improvements #3261

pjmuller opened this issue Sep 24, 2024 · 3 comments

Comments

@pjmuller
Copy link

Feature

@adrianthedev
Copy link
Collaborator

adrianthedev commented Oct 5, 2024

  • is it possible to localize/modify the tooltips of the bold/italic/... buttons

I guess we need a mechanism to pass some i18n strings from Rails to JS and then pass them to rhino. Not sure how easy it is to implement them into rhino/TipTap

  • the color button don't have tooltips

We can add them. Same applies for i18n

We need to add support for that

  • underline: could we add this button? (trix had it...)

THis can be added to the Avo field or to rhino itself.


This is the kind of issue that steers me to making this an extra paid add-on to Avo.
it will take so much of our time to add things everytime.

The alternative is to spend that time to build a comprehensive plugin system, but I'm not sure that's the right option either as Avo is using Rhino, which uses TipTap, which uses ProseMirror. So many abstraction layers and another thing to architect and maintain in the future.


My main question is, would you be open to contribute those features to the rhino field? 😬
The follow-up is, if not, would you be open to support us adding them?

Copy link
Contributor

This issue has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label Oct 22, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Closing this because there was no activity for the past 15 days. Feel free to reopen if new information pops up ✌️

@github-actions github-actions bot closed this as completed Nov 7, 2024
@adrianthedev adrianthedev removed the Stale label Nov 7, 2024
@adrianthedev adrianthedev reopened this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants