Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] CTHL-1780: Translation into modules and use packages for parse and check #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] CTHL-1780: Translation into modules and use packages for parse and check #12

wants to merge 2 commits into from

Conversation

AlexanderAsmakov
Copy link
Collaborator

  1. To modules
  2. Refactor parse (for test)

CTHL-1780:
5e67dc4 
1) To modules
2) Refactor parse for test
@AlexanderAsmakov AlexanderAsmakov changed the title CTHL-1780: Translation into modules and use packages for parse and check [WIP] CTHL-1780: Translation into modules and use packages for parse and check Jul 23, 2021
ShamanR
ShamanR suggested changes Jul 23, 2021
View reviewed changes
parse.go
//buildPkg, err := build.ImportDir(dir, build.FindOnly)
//
//if err != nil {
// return nil, nil, nil, nil, fmt.Errorf("could not create build package of %q: %v", file, err)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are this comments useful?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course not.
I'm currently testing it. After that I will clean up everything and remove [WIP] from the header :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the project still alive?

Merge branch 'master' into CTHL-1780-fix-parse-and-modules
d723c63 
# Conflicts:
#	.travis.yml
#	scripts/lint.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JekaMas JekaMas JekaMas left review comments

@ShamanR ShamanR ShamanR requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexanderAsmakov @JekaMas @ShamanR