From 9c1499bab432e6c66d86d0dcf14604cc8dd17dbe Mon Sep 17 00:00:00 2001 From: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> Date: Fri, 20 Sep 2024 12:12:39 -0500 Subject: [PATCH] nit Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> --- api/jsonrpc/server.go | 5 ++--- tests/integration/integration.go | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/api/jsonrpc/server.go b/api/jsonrpc/server.go index 537ff2e208..fc4769a501 100644 --- a/api/jsonrpc/server.go +++ b/api/jsonrpc/server.go @@ -152,8 +152,7 @@ type GetABIReply struct { func (j *JSONRPCServer) GetABI(_ *http.Request, _ *GetABIArgs, reply *GetABIReply) error { actionRegistry, outputRegistry := j.vm.ActionRegistry(), j.vm.OutputRegistry() - // Must dereference aliased type to call GetRegisteredTypes - vmABI, err := abi.NewABI((*actionRegistry).GetRegisteredTypes(), (*outputRegistry).GetRegisteredTypes()) + vmABI, err := abi.NewABI(actionRegistry.GetRegisteredTypes(), (*outputRegistry).GetRegisteredTypes()) if err != nil { return err } @@ -180,7 +179,7 @@ func (j *JSONRPCServer) Execute( defer span.End() actionRegistry := j.vm.ActionRegistry() - action, err := (*actionRegistry).Unmarshal(codec.NewReader(args.Action, len(args.Action))) + action, err := actionRegistry.Unmarshal(codec.NewReader(args.Action, len(args.Action))) if err != nil { return fmt.Errorf("failed to unmashal action: %w", err) } diff --git a/tests/integration/integration.go b/tests/integration/integration.go index a1105c7aca..acdcfbd040 100644 --- a/tests/integration/integration.go +++ b/tests/integration/integration.go @@ -306,7 +306,7 @@ var _ = ginkgo.Describe("[HyperSDK APIs]", func() { ginkgo.By("Gets ABI") actionRegistry, outputRegistry := instances[0].vm.ActionRegistry(), instances[0].vm.OutputRegistry() - expectedABI, err := abi.NewABI((*actionRegistry).GetRegisteredTypes(), (*outputRegistry).GetRegisteredTypes()) + expectedABI, err := abi.NewABI(actionRegistry.GetRegisteredTypes(), (*outputRegistry).GetRegisteredTypes()) require.NoError(err) workload.GetABI(ctx, require, uris, expectedABI)