From ec180a7d4ec90ab3b0f62e7de39856565fbb8c75 Mon Sep 17 00:00:00 2001 From: Ron Kuris Date: Thu, 10 Oct 2024 10:22:40 -1000 Subject: [PATCH] Remove histograms Rumor has it these are very expensive to compute, so let's remove them for now. --- firewood/src/merkle.rs | 3 --- storage/src/nodestore.rs | 1 - 2 files changed, 4 deletions(-) diff --git a/firewood/src/merkle.rs b/firewood/src/merkle.rs index e42f2594f..805a98e6c 100644 --- a/firewood/src/merkle.rs +++ b/firewood/src/merkle.rs @@ -416,9 +416,6 @@ impl Merkle> { /// Map `key` to `value` in the trie. /// Each element of key is 2 nibbles. pub fn insert(&mut self, key: &[u8], value: Box<[u8]>) -> Result<(), MerkleError> { - histogram!("firewood.insert.key.length").record(key.len() as f64); - histogram!("firewood.insert.data.length").record(value.len() as f64); - let key = Path::from_nibbles_iterator(NibblesIterator::new(key)); let root = self.nodestore.mut_root(); diff --git a/storage/src/nodestore.rs b/storage/src/nodestore.rs index 32cff965c..d701fa604 100644 --- a/storage/src/nodestore.rs +++ b/storage/src/nodestore.rs @@ -492,7 +492,6 @@ impl NodeStore, S> { /// Also returns the index of the free list the node was allocated from. pub fn allocate_node(&mut self, node: &Node) -> Result<(LinearAddress, AreaIndex), Error> { let stored_area_size = Self::stored_len(node); - histogram!("firewood.node_size").record(stored_area_size as f64); // Attempt to allocate from a free list. // If we can't allocate from a free list, allocate past the existing