Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix to import and build #5342

Conversation

SakodaShintaro
Copy link
Contributor

@SakodaShintaro SakodaShintaro commented Oct 17, 2024

Description

This pull request fixed two problems in release/2024.09.

(1) Missing commit

In the transport_drivers repository, the commit with the id "abf8aa8e171f33e0acd6d845c3d795192c964e9c" is missing.

This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

https://github.com/autowarefoundation/transport_drivers/tree/abf8aa8e171f33e0acd6d845c3d795192c964e9c

To resolve this, I have updated the commit ID to the latest on the main branch.

(2) Nebula build error

In this version I get the following build error:

--- stderr: nebula_hw_interfaces                                                                                          
** WARNING ** io features related to pcap will be disabled
In file included from /home/shintarosakoda/autoware_build_test/src/sensor_component/external/nebula/nebula_hw_interfaces/include/nebula_hw_interfaces/nebula_hw_interfaces_hesai/hesai_hw_interface.hpp:19,
                 from /home/shintarosakoda/autoware_build_test/src/sensor_component/external/nebula/nebula_hw_interfaces/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp:1:
/home/shintarosakoda/autoware_build_test/src/sensor_component/external/nebula/nebula_hw_interfaces/include/nebula_hw_interfaces/nebula_hw_interfaces_hesai/hesai_cmd_response.hpp: In function 'std::ostream& nebula::operator<<(std::ostream&, const nebula::HesaiInventory&)':
/home/shintarosakoda/autoware_build_test/src/sensor_component/external/nebula/nebula_hw_interfaces/include/nebula_hw_interfaces/nebula_hw_interfaces_hesai/hesai_cmd_response.hpp:200:30: error: 'setfill' is not a member of 'std'; did you mean 'fill'?
  200 |       ss << std::hex << std::setfill('0') << std::setw(2) << (static_cast<int>(arg.mac[i]) & 0xff)
      |                              ^~~~~~~
      |                              fill
/home/shintarosakoda/autoware_build_test/src/sensor_component/external/nebula/nebula_hw_interfaces/include/nebula_hw_interfaces/nebula_hw_interfaces_hesai/hesai_cmd_response.hpp:200:51: error: 'setw' is not a member of 'std'; did you mean 'set'?
  200 |       ss << std::hex << std::setfill('0') << std::setw(2) << (static_cast<int>(arg.mac[i]) & 0xff)
      |                                                   ^~~~
      |                                                   set
/home/shintarosakoda/autoware_build_test/src/sensor_component/external/nebula/nebula_hw_interfaces/include/nebula_hw_interfaces/nebula_hw_interfaces_hesai/hesai_cmd_response.hpp:203:28: error: 'setfill' is not a member of 'std'; did you mean 'fill'?
  203 |     ss << std::hex << std::setfill('0') << std::setw(2)
      |                            ^~~~~~~
      |                            fill
/home/shintarosakoda/autoware_build_test/src/sensor_component/external/nebula/nebula_hw_interfaces/include/nebula_hw_interfaces/nebula_hw_interfaces_hesai/hesai_cmd_response.hpp:203:49: error: 'setw' is not a member of 'std'; did you mean 'set'?
  203 |     ss << std::hex << std::setfill('0') << std::setw(2)
      |                                                 ^~~~
      |                                                 set
gmake[2]: *** [CMakeFiles/nebula_hw_interfaces_hesai.dir/build.make:76: CMakeFiles/nebula_hw_interfaces_hesai.dir/src/nebula_hesai_hw_interfaces/hesai_hw_interface.cpp.o] エラー 1
gmake[1]: *** [CMakeFiles/Makefile2:143: CMakeFiles/nebula_hw_interfaces_hesai.dir/all] エラー 2
gmake: *** [Makefile:146: all] エラー 2
---
Failed   <<< nebula_hw_interfaces [29.6s, exited with code 2]

This has been fixed in

I have updated the commit ID to this.

Tests performed

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro SakodaShintaro marked this pull request as ready for review October 17, 2024 07:39
@mitsudome-r mitsudome-r added the tag:run-health-check Run health-check label Oct 17, 2024
@mitsudome-r
Copy link
Member

The health check is probably failing due to the change in the workflow files since 2024.09 was released so I have checked the build locally instead and confirmed that build passes with the new commit hash.

@mitsudome-r mitsudome-r merged commit 68b669c into autowarefoundation:release/2024.09 Oct 17, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants