From 2bce8901d21c7d1deff65a7f1bad4ec54e38a4bc Mon Sep 17 00:00:00 2001 From: Esteve Fernandez Date: Wed, 10 Apr 2024 13:06:39 +0200 Subject: [PATCH] fix(autoware_behavior_path_external_request_lane_change_module): fix clang-tidy issues Signed-off-by: Esteve Fernandez --- ...t_behavior_path_planner_node_interface.cpp | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/planning/behavior_path_external_request_lane_change_module/test/test_behavior_path_planner_node_interface.cpp b/planning/behavior_path_external_request_lane_change_module/test/test_behavior_path_planner_node_interface.cpp index 3b1c9dba1fbf0..aea0a4e651066 100644 --- a/planning/behavior_path_external_request_lane_change_module/test/test_behavior_path_planner_node_interface.cpp +++ b/planning/behavior_path_external_request_lane_change_module/test/test_behavior_path_planner_node_interface.cpp @@ -25,7 +25,7 @@ using ::behavior_path_planner::BehaviorPathPlannerNode; using planning_test_utils::PlanningInterfaceTestManager; -std::shared_ptr generateTestManager() +std::shared_ptr generate_test_manager() { auto test_manager = std::make_shared(); @@ -40,7 +40,7 @@ std::shared_ptr generateTestManager() return test_manager; } -std::shared_ptr generateNode() +std::shared_ptr generate_node() { auto node_options = rclcpp::NodeOptions{}; const auto planning_test_utils_dir = @@ -74,9 +74,9 @@ std::shared_ptr generateNode() return std::make_shared(node_options); } -void publishMandatoryTopics( - std::shared_ptr test_manager, - std::shared_ptr test_target_node) +void publish_mandatory_topics( + const std::shared_ptr& test_manager, + const std::shared_ptr& test_target_node) { // publish necessary topics from test_manager test_manager->publishInitialPose(test_target_node, "behavior_path_planner/input/odometry"); @@ -96,10 +96,10 @@ void publishMandatoryTopics( TEST(PlanningModuleInterfaceTest, NodeTestWithExceptionRoute) { rclcpp::init(0, nullptr); - auto test_manager = generateTestManager(); - auto test_target_node = generateNode(); + auto test_manager = generate_test_manager(); + auto test_target_node = generate_node(); - publishMandatoryTopics(test_manager, test_target_node); + publish_mandatory_topics(test_manager, test_target_node); // test for normal trajectory ASSERT_NO_THROW_WITH_ERROR_MSG(test_manager->testWithBehaviorNominalRoute(test_target_node)); @@ -114,9 +114,9 @@ TEST(PlanningModuleInterfaceTest, NodeTestWithOffTrackEgoPose) { rclcpp::init(0, nullptr); - auto test_manager = generateTestManager(); - auto test_target_node = generateNode(); - publishMandatoryTopics(test_manager, test_target_node); + auto test_manager = generate_test_manager(); + auto test_target_node = generate_node(); + publish_mandatory_topics(test_manager, test_target_node); // test for normal trajectory ASSERT_NO_THROW_WITH_ERROR_MSG(test_manager->testWithBehaviorNominalRoute(test_target_node));