Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root logger is not avilible to avocado tests after the 92.0 LTS #3833

Open
richtja opened this issue Oct 20, 2021 · 4 comments
Open

Root logger is not avilible to avocado tests after the 92.0 LTS #3833

richtja opened this issue Oct 20, 2021 · 4 comments

Comments

@richtja
Copy link

richtja commented Oct 20, 2021

In b2459dd the avocado stopped using the logs from root logger. Every avocado log are under avocado namespace now. This change was already accepted in avocado-vt. With those changes, every avocado-vt test has to use avocado namespace for logging, otherwise the logs will be lost, because the logs to root logger won't be used by avocado output. This is also part of Avocado 92.0 LTS version. As a solution, might be approach from avocado-vt adbfa56

@smitterl
Copy link
Contributor

I'm updating my script, but @richtja do I understand this correctly, do we now have to add an additional line of boilerplate code to each and every test script - I counted 539 test scripts today only in this libvirt provider - to make sure the logs are not lost?

@richtja
Copy link
Author

richtja commented Jan 18, 2022

Hi @smitterl If those scripts are using the root logger, unfortunately yes the change is necessary, because now the avocado only captures messages from the Avocado namespace context.

@smitterl
Copy link
Contributor

$ grep -Rl "logging\."|grep ".py"|wc -l
465

@Yingshun
Copy link
Contributor

Yingshun commented Jan 19, 2022

The following is our latest status(update here to inform anyone interested in this issue):
updated the existing files in tp-libvirt/libvirt: #3994
updated the existing files in tp-libvirt/provider: #3995
updated v2v files: #3983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants