Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the usage of test.error()/test.fail()/test.cancel() #3157

Open
dzhengfy opened this issue Nov 16, 2020 · 1 comment
Open

About the usage of test.error()/test.fail()/test.cancel() #3157

dzhengfy opened this issue Nov 16, 2020 · 1 comment

Comments

@dzhengfy
Copy link
Contributor

dzhengfy commented Nov 16, 2020

Recently we had some discussion to synchronize the same understanding for the usage of above functions in the subject.
Below is the current understanding we have now. Welcome to comment!

  • The basic strategy is that we should skip tests as little as we can

  • test.fail() - used only when failures happens for case checkpoints

  • test.error() - used when

    1. vm starts failed
    2. create disk failed
    3. required package missing
    4. not enough vms
    5. incorrect parameters
    6. and any failure for test environment setup
  • test.cancel() - used when

  1. The feature does not support with current libvirt version or architecture
  2. The hardware configuration does not support the test
@dzhengfy
Copy link
Contributor Author

@sathnaga Welcome your opinions :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant