Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze utils_test/libvirt.py #3006

Open
dzhengfy opened this issue Aug 18, 2020 · 2 comments
Open

Freeze utils_test/libvirt.py #3006

dzhengfy opened this issue Aug 18, 2020 · 2 comments

Comments

@dzhengfy
Copy link
Contributor

@sathnaga @balamuruhans @smitterl ,

Here we have a new plan for virttest/utils_test/libvirt.py.
As this file is becoming bigger and bigger, there are too many kinds of functions mixed up in this file. The readability and usability is also getting worse and worse. So we plan to lock down this file that no more new functions are allowed to be added into it. And at same time, we plan to create a new folder named with virttest/utils_libvirt, and will create multiple files under utils_libvirt/ by feature on demand, such as memory, cpu, migration and so on. Those files are used to contain the utility functions which are mostly virsh commands related.

So welcome your comments. And if no objection, please help avoid of new functions in libvirt.py any more.
Thanks a lot.

@smitterl
Copy link
Contributor

smitterl commented Sep 2, 2020

@dzhengfy Sounds good 👍

@sathnaga
Copy link
Member

sathnaga commented Dec 2, 2020

@dzhengfy sounds grt,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants