Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Front] Encryption/Decryption for Upload/Download #6

Closed
its-colby opened this issue Sep 18, 2024 · 1 comment
Closed

[Front] Encryption/Decryption for Upload/Download #6

its-colby opened this issue Sep 18, 2024 · 1 comment
Labels
high priority poc Proof of Concept

Comments

@its-colby
Copy link
Collaborator

its-colby commented Sep 18, 2024

  • encapsulate all non UI logic so that it can be added to Auto SDK
  • allow user to set password, use symmetric cipher for decrypt/encrypt, eg AES

Flow: User sets password, password is saved in local storage (and user saves password to his own password manager). Crypto library is used to derive symmetric key from password, AES is used to encrypt, + MAC tag. Encrypted file sent to backend and treated like any other file. When file downloaded on frontend, frontend will attempt to decrypt with saved password from local storage. If incorrect MAC tag or no saved password, it will prompt user to enter password, then attempt decryption.

For encrypted files, if they are cached on the user's own machine (the client machine), then they will be cached in decrypted form.

The backend should not be aware of any passwords, salted passwords, or distinguish between encrypted and un-encrypted (plaintext) files.

@jfrank-summit jfrank-summit added the mvp Minimum viable product label Sep 30, 2024
@jfrank-summit jfrank-summit added this to the Auto Drive MVP milestone Sep 30, 2024
@its-colby its-colby added high priority poc Proof of Concept and removed mvp Minimum viable product labels Oct 14, 2024
@clostao
Copy link
Collaborator

clostao commented Oct 29, 2024

There’s an issue with downloading folders that contain encrypted files. Currently, folders are packaged as ZIP files for download, but the files within an encrypted folder are also downloaded in their encrypted form, which isn’t ideal for user accessibility.

To resolve this, I suggest encrypting the entire ZIP file for folders that require encryption. This way, users receive a single encrypted ZIP file, ensuring that only the folder itself is encrypted, rather than each file individually.

@clostao clostao closed this as completed Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority poc Proof of Concept
Projects
None yet
Development

No branches or pull requests

3 participants