Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Make subroutines of _do_traditional to clarify the workflow #167 #171

Closed
wants to merge 11 commits into from
Closed

[refactor] Make subroutines of _do_traditional to clarify the workflow #167 #171

wants to merge 11 commits into from

Commits on Apr 12, 2021

  1. [refactor] Separate processing inside BaseTask._search() function 

    Since the readability of the function was quite bad,
I separated the processing.
I mostly copied and pasted the original processing and
checked if we can run some examples.
    @nabenabe0928
    nabenabe0928 committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    7186348 View commit details
    Browse the repository at this point in the history

  2. [refactor] Add _search_settings to make _search() function shorter

    @nabenabe0928
    nabenabe0928 committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    ff1d7d3 View commit details
    Browse the repository at this point in the history

  3. [fix] Resolve all the mypy issues

    @nabenabe0928
    nabenabe0928 committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    ec1a508 View commit details
    Browse the repository at this point in the history

  4. [refactor] Make subroutines of _do_traditional to clarify the workflow

    @nabenabe0928
    nabenabe0928 committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    49c7d3a View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. [fix] Fix a condition

    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    1cd189d View commit details
    Browse the repository at this point in the history

  2. [fix] Delete a TODO line because finished it

    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    8a203d8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'refactor_development' into refactor_basetask2_do_tradit… 

    …ional_prediction
    @nabenabe0928
    nabenabe0928 authored Apr 14, 2021
    Configuration menu
    Copy the full SHA
    a96ba53 View commit details
    Browse the repository at this point in the history

  4. [fix] Fix mypy issues

    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    8cffabe View commit details
    Browse the repository at this point in the history

  5. [fix] Fix flake8 issues

    @nabenabe0928
    nabenabe0928 committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    f17b543 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. [fix] Fix a bug from the rebase in test_api

    @nabenabe0928
    nabenabe0928 committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    ab42b57 View commit details
    Browse the repository at this point in the history

  2. [fix] Disable the raise Error in the case of CRASH in the traditional… 

    … training
    @nabenabe0928
    nabenabe0928 committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    2df88a4 View commit details
    Browse the repository at this point in the history