Add support for secondary dispatching on LR2 #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/tooling
josephschorr
force-pushed
the
lr-secondary-dispatch
branch
3 times, most recently
from
564b30d
to
27a1453
Compare
ecordell
reviewed
Sep 18, 2024
|
|
||
| const secondaryCursorPrefix = "$$secondary:" | ||
|
|
||
| func publishClient[Q requestMessageWithCursor, R responseMessageWithCursor](ctx context.Context, client receiver[R], stream dispatch.Stream[R], secondaryDispatchName string) error { |
There was a problem hiding this comment.
Its used for the type of the incoming message, off of which I grab the cursor. I could have the req just be that interface directly, but I always prefer well-typed wherever possible
internal/dispatch/remote/cluster.go
Outdated
|
|
||
| // If no secondary dispatches are defined, just invoke directly. | ||
| if len(cr.secondaryDispatchExprs) == 0 || len(cr.secondaryDispatch) == 0 { | ||
| return publishClient[Q](withTimeout, client, stream, "") |
There was a problem hiding this comment.
define a constant for the primary dispatcher name?
| Relation: "...", | ||
| }, | ||
| OptionalCursor: &v1.Cursor{ | ||
| Sections: []string{secondaryCursorPrefix + "tertiary"}, |
There was a problem hiding this comment.
add one extra test case where the expression is "['secondary']" and the cursor is also for secondary?
josephschorr
force-pushed
the
lr-secondary-dispatch
branch
from
27a1453
to
411479e
Compare
josephschorr
force-pushed
the
lr-secondary-dispatch
branch
from
411479e
to
543e6e0
Compare
ecordell
approved these changes
Sep 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.