Add goreleaser configuration to push Windows package to Chocolatey #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzelinskie
reviewed
Apr 26, 2024
github-actions
bot
added
the
area/tooling
josephschorr
force-pushed
the
choco
branch
3 times, most recently
from
cccb0f5
to
6753e76
Compare
jzelinskie
previously approved these changes
May 1, 2024
|
Looks like goreleaser needs a bit more: |
|
Looks like adding # Can be used to change the archive formats for specific GOOSs.
# Most common use case is to archive as zip on Windows.
format_overrides:
- # Which GOOS to override the format for.
goos: windows
# The format to use for the given GOOS.
#
# Valid options are `tar.gz`, `tgz`, `tar.xz`, `txz`, tar`, `gz`, `zip`, `binary`, and `none`.
format: zipshould fix it per goreleaser/goreleaser#4450 |
jzelinskie
reviewed
Jul 1, 2024
.goreleaser.yml
Outdated
| license_url: "https://github.com/authzed/spicedb/blob/main/LICENSE" | ||
| require_license_acceptance: false | ||
| project_source_url: "https://github.com/authzed/spicedb" | ||
| docs_url: "https://docs.authzed.com" |
jzelinskie
reviewed
Jul 1, 2024
.goreleaser.yml
Outdated
| api_key: "{{ .Env.CHOCOLATEY_API_KEY }}" | ||
| source_repo: "https://push.chocolatey.org/" | ||
| skip_publish: false | ||
| goamd64: "v1" |
There was a problem hiding this comment.
let's remove any properties that are the default for better signal/noise ratio:
- goamd64
- skip_publish
- require_license_acceptance
jzelinskie
previously approved these changes
Jul 1, 2024
josephschorr
force-pushed
the
choco
branch
8 times, most recently
from
ff4b549
to
ba76931
Compare
jzelinskie
reviewed
Jul 3, 2024
.github/workflows/security.yaml
Outdated
| @@ -1,6 +1,6 @@ | |||
| --- | |||
| name: "Security" | |||
| on: # yamllint disable-line rule:truthy | |||
| on: # yamllint disable-line rule:truthy | |||
jzelinskie
reviewed
Jul 3, 2024
.github/workflows/release.yaml
Outdated
| @@ -45,4 +76,6 @@ jobs: | |||
| HOMEBREW_TAP_GITHUB_TOKEN: "${{ secrets.HOMEBREW_TAP_GITHUB_TOKEN }}" | |||
| GORELEASER_KEY: "${{ secrets.GORELEASER_KEY }}" | |||
| GEMFURY_PUSH_TOKEN: "${{ secrets.GEMFURY_PUSH_TOKEN }}" | |||
| - name: "Release snap" | |||
| env: | |||
There was a problem hiding this comment.
was this an accident? this "step" has nothing to run?
There was a problem hiding this comment.
That's super odd.... I'll revert; I wonder if I accidentally hit tab on Copilot
josephschorr
force-pushed
the
choco
branch
2 times, most recently
from
a7529a7
to
d7a8a0d
Compare
… as it needs to run on a windows machine
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.