Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Server warnings for slow permissions definitions #2058

Open
jzelinskie opened this issue Sep 6, 2024 · 1 comment
Open

Language Server warnings for slow permissions definitions #2058

jzelinskie opened this issue Sep 6, 2024 · 1 comment
Labels
area/lsp Affects the language server area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) kind/proposal Something fundamentally needs to change

Comments

@jzelinskie
Copy link
Member

Problem Statement

Currently it's somewhat difficult to reason about the performance of a particular permission definition during schema development.

Solution Brainstorm

While we cannot know the distribution of data in the system until we're working against a live SpiceDB deployment, we can detect the level of nesting and use of costly operators (intersection, negation) to come up with a score and throw a warning when a definition is over a particular score.

@jzelinskie jzelinskie added area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) kind/proposal Something fundamentally needs to change area/lsp Affects the language server labels Sep 6, 2024
@tstirrat15
Copy link
Contributor

This will probably be somewhere downstream of the composable schema proposal. We'll need a reachability graph at compile time, which I don't think we currently have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lsp Affects the language server area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) kind/proposal Something fundamentally needs to change
Projects
None yet
Development

No branches or pull requests

2 participants