Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove buff generation + diffing for now #220

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

tstirrat15
Copy link
Contributor

Description

This step has been consistently failing for this repo because the version of gRPC we want isn't provided by brew. We want to move to using buf remote plugins for this anyway, so we can reimplement this when we make that change.

Changes

  • Disable step that generates and diffs protobuf

Testing

Review. See that things go green.

@tstirrat15 tstirrat15 requested a review from a team as a code owner October 31, 2024 21:35
@tstirrat15 tstirrat15 added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 76ce6a1 Oct 31, 2024
13 checks passed
@tstirrat15 tstirrat15 deleted the disable-buf-diff-workflow-step branch October 31, 2024 22:24
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants