Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more realistic bulk import example #219

Merged
merged 7 commits into from
Oct 31, 2024

Conversation

tstirrat15
Copy link
Contributor

@tstirrat15 tstirrat15 commented Oct 31, 2024

Description

We've gotten a couple of questions around the behavior of ImportBulkRelationships and how to do batching with it. This is intended as an example of a slightly-more-real-world batching strategy. I intended to use it in the documentation, but I hadn't considered that the python client speaks in terms of iterators, which is pythonic but not easily grokkable for non-python devs, so I won't use this example in the documentation, but it'll probably be helpful to have it in the examples dir.

Changes

  • Add a new example file

Testing

Start a serve-testing instance and run the example against it

@tstirrat15 tstirrat15 requested a review from a team as a code owner October 31, 2024 19:35
Copy link

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@tstirrat15 tstirrat15 force-pushed the add-more-realistic-bulk-import-example branch from f4a8f87 to 38ed6cc Compare October 31, 2024 22:27
@tstirrat15 tstirrat15 added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit c9f5221 Oct 31, 2024
13 checks passed
@tstirrat15 tstirrat15 deleted the add-more-realistic-bulk-import-example branch October 31, 2024 22:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants