Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popup Abort Signals #1626

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Popup Abort Signals #1626

merged 6 commits into from
Aug 20, 2024

Conversation

smujmaiku
Copy link
Contributor

@smujmaiku smujmaiku commented Aug 17, 2024 •
edited
Loading

Closes: #1625

  • Adds popupSignal property to signinPopup and signoutPop methods to cancel windows similar to fetch signal

Checklist

  • This PR makes changes to the public API
  • I have included links for closing relevant issue numbers

@smujmaiku smujmaiku changed the title Draft: 1625 abort popup Draft: 1625 Abort Popup Aug 17, 2024
@smujmaiku smujmaiku changed the title Draft: 1625 Abort Popup 1625 Abort Popup Aug 17, 2024
@smujmaiku smujmaiku changed the title 1625 Abort Popup 1625 Popup Abort Signals Aug 17, 2024
@pamapa pamapa changed the title 1625 Popup Abort Signals Popup Abort Signals Aug 20, 2024
@pamapa pamapa added this to the 3.1.0 milestone Aug 20, 2024
@pamapa pamapa merged commit ad05ded into authts:main Aug 20, 2024
2 checks passed
@pamapa
Copy link
Member

pamapa commented Aug 20, 2024

thanks for contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamapa pamapa pamapa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

Canceling a Popup From the Parent
2 participants
@smujmaiku @pamapa