Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial tvOS support #959

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

mrbrentkelly
Copy link

@mrbrentkelly mrbrentkelly commented Aug 20, 2024

Changes

The Auth0.swift library supports tvOS, but when trying to link react-native-auth0 to a tvOS project, there are compilation issues in its native swift bridging code due to accessing APIs that aren't available on tvOS (e.g. Auth0.webAuth, WebAuthentication etc).

This PR add tvos as a supported platform in the react-native-auth0 podspec and wraps applicable pieces of the native swift bridging code in #if os(tvOS) .. #else .. ##endif statements.

This allows the react-native-auth0 lib to be compiled for tvOS whilst not changing the iOS side at all.

References

Testing

  • Verified code changes build and run successfully on a tvOS RN project.
  • Verified code changes build and run successfully on an iOS RN project.
  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant