Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the authParams type #849

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ben-qiu
Copy link

@ben-qiu ben-qiu commented Jan 5, 2024

Changes

Please describe both what is changing and why this is important. Include:

authParams in PasswordlessWithEmailOptions and PasswordlessWithSMSOptions should be an object, when passes as a string, it will throw an error bad.authParams: error in authParams - invalid type: string (expected object)

  • Fix the authParams type in PasswordlessWithEmailOptions and PasswordlessWithSMSOptions. It should be an object

References

Please include relevant links supporting this change such as a:

  • support ticket
  • community post
  • StackOverflow post
  • support forum thread

Please note any links that are not publicly accessible.

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant