Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide error description in android #751

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

poovamraj
Copy link
Contributor

Changes

With this change, we will add error description to our error message similar to iOS. This will allow users to get custom error sent through actions in server.

References

#749

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Local Testing

{"nativeStackAndroid":[{"lineNumber":202,"file":"OAuthManager.kt","methodName":"assertNoError","class":"com.auth0.android.provider.OAuthManager"},{"lineNumber":95,"file":"OAuthManager.kt","methodName":"resume","class":"com.auth0.android.provider.OAuthManager"},{"lineNumber":77,"file":"WebAuthProvider.kt","methodName":"resume","class":"com.auth0.android.provider.WebAuthProvider"},{"lineNumber":94,"file":"AuthenticationActivity.kt","methodName":"deliverAuthenticationResult$auth0_release","class":"com.auth0.android.provider.AuthenticationActivity"},{"lineNumber":58,"file":"AuthenticationActivity.kt","methodName":"onResume","class":"com.auth0.android.provider.AuthenticationActivity"},{"lineNumber":1603,"file":"Instrumentation.java","methodName":"callActivityOnResume","class":"android.app.Instrumentation"},{"lineNumber":8743,"file":"Activity.java","methodName":"performResume","class":"android.app.Activity"},{"lineNumber":4951,"file":"ActivityThread.java","methodName":"performResumeActivity","class":"android.app.ActivityThread"},{"lineNumber":4994,"file":"ActivityThread.java","methodName":"handleResumeActivity","class":"android.app.ActivityThread"},{"lineNumber":57,"file":"ResumeActivityItem.java","methodName":"execute","class":"android.app.servertransaction.ResumeActivityItem"},{"lineNumber":45,"file":"ActivityTransactionItem.java","methodName":"execute","class":"android.app.servertransaction.ActivityTransactionItem"},{"lineNumber":180,"file":"TransactionExecutor.java","methodName":"executeLifecycleState","class":"android.app.servertransaction.TransactionExecutor"},{"lineNumber":98,"file":"TransactionExecutor.java","methodName":"execute","class":"android.app.servertransaction.TransactionExecutor"},{"lineNumber":2443,"file":"ActivityThread.java","methodName":"handleMessage","class":"android.app.ActivityThread$H"},{"lineNumber":106,"file":"Handler.java","methodName":"dispatchMessage","class":"android.os.Handler"},{"lineNumber":205,"file":"Looper.java","methodName":"loopOnce","class":"android.os.Looper"},{"lineNumber":294,"file":"Looper.java","methodName":"loop","class":"android.os.Looper"},{"lineNumber":8176,"file":"ActivityThread.java","methodName":"main","class":"android.app.ActivityThread"},{"lineNumber":-2,"file":"Method.java","methodName":"invoke","class":"java.lang.reflect.Method"},{"lineNumber":552,"file":"RuntimeInit.java","methodName":"run","class":"com.android.internal.os.RuntimeInit$MethodAndArgsCaller"},{"lineNumber":971,"file":"ZygoteInit.java","methodName":"main","class":"com.android.internal.os.ZygoteInit"}],"userInfo":null,"message":"An error occurred when trying to authenticate with the server. CAUSE: Transaction failed, integrity_token not provided","code":"access_denied"}

@poovamraj poovamraj requested a review from Widcket October 5, 2023 07:34
@poovamraj poovamraj enabled auto-merge (squash) October 5, 2023 11:04
@poovamraj poovamraj merged commit 80c4d26 into master Oct 5, 2023
7 checks passed
@poovamraj poovamraj deleted the detailed-error-description-in-android branch October 5, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants