Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Custom Prompts #930

Merged

Conversation

developerkunal
Copy link
Contributor

@developerkunal developerkunal commented Jul 24, 2024

🔧 Changes

  • Added support for custom partial prompts on the Prompts Handler.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 92.39130% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.18%. Comparing base (9ab33c3) to head (67c39ca).

Files Patch % Lines
src/tools/auth0/handlers/prompts.ts 91.37% 0 Missing and 5 partials ⚠️
src/context/directory/handlers/prompts.ts 94.11% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #930      +/-   ##
==========================================
+ Coverage   84.05%   84.18%   +0.13%     
==========================================
  Files         116      116              
  Lines        3737     3813      +76     
  Branches      727      743      +16     
==========================================
+ Hits         3141     3210      +69     
  Misses        331      331              
- Partials      265      272       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@developerkunal developerkunal marked this pull request as ready for review July 26, 2024 06:55
@developerkunal developerkunal requested a review from a team as a code owner July 26, 2024 06:55
Copy link

@acwest acwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have more testing of error cases, but that appears to be difficult in many of our use cases

@developerkunal developerkunal force-pushed the DXCDT-625-Support-for-custom-prompts-on-auth0-deploy-cli branch from 05fc876 to a6c735d Compare August 1, 2024 17:15
@developerkunal developerkunal merged commit 73e8f26 into master Aug 1, 2024
7 checks passed
@developerkunal developerkunal deleted the DXCDT-625-Support-for-custom-prompts-on-auth0-deploy-cli branch August 1, 2024 18:34
@ifyoumakeit
Copy link

Are there any examples of what the tenant.yaml should look like to use this?

kushalshit27 pushed a commit that referenced this pull request Sep 26, 2024
* Add Support for Custom Prompts

* Fixed Linting

* Fixed context.test.js

* Add E2e Test

* Fix E2e Test

* Fix E2e Test

* Fix E2E Tests

* Update structure

* Updated Testcase for checking the file.

* Update - Used _getRestClient for making requests.

* Added _getRestClient Mock

* Fixed Put Request.

* Bump chai from 4.4.1 to 4.5.0 (#932)

Bumps [chai](https://github.com/chaijs/chai) from 4.4.1 to 4.5.0.
- [Release notes](https://github.com/chaijs/chai/releases)
- [Changelog](https://github.com/chaijs/chai/blob/main/History.md)
- [Commits](chaijs/chai@v4.4.1...v4.5.0)

---
updated-dependencies:
- dependency-name: chai
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* FIx Formatting

* reverted prompt types

* Fixed Linting and schema

* Make changes in Schema for partial prompts

* Update codeowner file with new GitHub team name (#931)

Co-authored-by: KunalOfficial <[email protected]>

* Removed consolelogs

* Fix back codeowners

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: stevenwong-okta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants