Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support signing up with organization membership #905

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

nandan-bhat
Copy link
Contributor

@nandan-bhat nandan-bhat commented Jun 21, 2024

🔧 Changes

  • A new property is_signup_enabled is added to the organization connections.

🔬 Testing

Create a config.json file similar to:

{
    "AUTH0_DOMAIN": "<YOUR_DOMAIN>",
    "AUTH0_CLIENT_ID": "<CLIENT_ID>",
    "AUTH0_CLIENT_SECRET": "<CLIENT_SECRET>",
    "AUTH0_INCLUDED_ONLY": ["organizations"],
    "AUTH0_ALLOW_DELETE": false
}

Use the following commands to import or export configs.

Export yaml: node lib/index.js export -c config.json -o ./local -f yaml
Import yaml: node lib/index.js import -c config.json --input_file ./local/tenant.yaml

is_signup_enabled is exported.
is_signup_enabled is imported on creation.
is_signup_enabled changes to existing enabled connections are detected and it is updated.

Important use-cases related to this change:

  • is_signup_enabled is valid only when the strategy is auth0. i.e is_signup_enabled will not available in non db connections.
  • is_signup_enabled can be set to true only when assign_membership_on_login is set true. However, you can set is_signup_enabled to false when assign_membership_on_login is set to false.

Continue the same test or json format as well.

🔬 Change Verification

  • With this PR changes, is_signup_enabled property value can be manipulated and changes can be seen on the auth0 dashboard.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

Copy link
Contributor

@developerkunal developerkunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.

@developerkunal developerkunal merged commit 9dc3067 into master Jun 21, 2024
7 checks passed
@developerkunal developerkunal deleted the feature/DXCDT-640 branch June 21, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants