Properly declare googletest dependency #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us support installing the library to the system, and then using it via `find_package()`. To test this, I ran `sudo cmake --install cmake/build`, observed that it completed with no errors, and then made a new CMake package that simply used `find_package(Au)`. Everything worked! Helps #215.
chiphogg
added
the
release notes: ⚙️ repo
geoffviola
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us support installing the library to the system, and then
using it via
find_package().To test this, I ran
sudo cmake --install cmake/build, observed that itcompleted with no errors, and then made a new CMake package that simply
used
find_package(Au). Everything worked!Helps #215.