Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename every BUILD file to BUILD.bazel #170

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Rename every BUILD file to BUILD.bazel #170

merged 4 commits into from
Aug 29, 2023

Conversation

chiphogg
Copy link
Contributor

@chiphogg chiphogg commented Aug 29, 2023

This should improve compatibility with MacOS and its case-insensitive filesystem.

Fixes #169.

This should improve compatibility with MacOS and its case-insensitive
filesystem.
@chiphogg chiphogg added the release notes: ⚙️ repo PR affecting the way the repository works label Aug 29, 2023
Copy link
Contributor

@geoffviola geoffviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This solution seems to match this conversation.

@nitishthatte
Copy link

Checking out this branch on my mac lets me build and run all the unit tests. Thanks!

There are some failing unit tests. But that's a separate issue.

@chiphogg chiphogg merged commit be0f010 into main Aug 29, 2023
9 checks passed
@chiphogg chiphogg deleted the mac-os#169 branch August 29, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: ⚙️ repo PR affecting the way the repository works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support unzipping on Mac OS
3 participants