Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch package to use fsspec for backends #233

Draft
wants to merge 66 commits into
base: main
Choose a base branch
from
Draft

Switch package to use fsspec for backends #233

wants to merge 66 commits into from

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Sep 13, 2024

Closes #230

This replaces our own backend implementations by supporting fsspec, which provides implementations for several different backends. I flattened the interface module and moved all classes to the top of the package.

As there exist no fsspec compatible implementation for Artifactory, I would propose we wait with this pull request until we no longer need to support Artifactory.

TODO:

  • owner() is not supported by fsspec
  • Add support for relative + absolute file path as fsspec supports it, e.g. fsspec.LocalFileSystem

image

@hagenw hagenw marked this pull request as draft September 13, 2024 07:17
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (937da89) to head (c15a569).

Additional details and impacted files
Files with missing lines Coverage Δ
audbackend/__init__.py 100.0% <100.0%> (ø)
audbackend/core/base.py 100.0% <100.0%> (ø)
audbackend/core/conftest.py 100.0% <100.0%> (ø)
audbackend/core/errors.py 100.0% <ø> (ø)
audbackend/core/maven.py 100.0% <100.0%> (ø)
audbackend/core/unversioned.py 100.0% <100.0%> (ø)
audbackend/core/utils.py 100.0% <ø> (ø)
audbackend/core/versioned.py 100.0% <100.0%> (ø)

This was referenced Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if we can integrate fsspec
1 participant