From 2a65f89cd54b8b8187240a1fdc288867b35f6b01 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E4=BE=9D=E4=BA=91?= Date: Mon, 19 Feb 2024 19:03:09 +0800 Subject: [PATCH] feat: change fulltext to do multi substring match (#1660) --- atuin-client/src/database.rs | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/atuin-client/src/database.rs b/atuin-client/src/database.rs index e67fe06dd87..572955f81c7 100644 --- a/atuin-client/src/database.rs +++ b/atuin-client/src/database.rs @@ -432,7 +432,6 @@ impl Database for Sqlite { match search_mode { SearchMode::Prefix => sql.and_where_like_left("command", query), - SearchMode::FullText => sql.and_where_like_any("command", query), _ => { // don't recompile the regex on successive calls! lazy_static! { @@ -453,6 +452,7 @@ impl Database for Sqlite { None => (false, query_part), }; + #[allow(clippy::if_same_then_else)] let param = if query_part == "|" { if !is_or { is_or = true; @@ -468,6 +468,8 @@ impl Database for Sqlite { format!("{glob}{term}{glob}") } else if is_inverse { format!("{glob}{query_part}{glob}") + } else if search_mode == SearchMode::FullText { + format!("{glob}{query_part}{glob}") } else { query_part.split("").join(glob) }; @@ -817,7 +819,10 @@ mod test { assert_search_eq(&db, SearchMode::FullText, FilterMode::Global, "/home", 1) .await .unwrap(); - assert_search_eq(&db, SearchMode::FullText, FilterMode::Global, "ls ", 0) + assert_search_eq(&db, SearchMode::FullText, FilterMode::Global, "ls ho", 1) + .await + .unwrap(); + assert_search_eq(&db, SearchMode::FullText, FilterMode::Global, "hm", 0) .await .unwrap(); }